Skip to content

ci: build the OCI image on merge-to-main, not on every PR - #2879

Merged
MarcusSorealheis merged 1 commit into
TraceMachina:mainfrom
b7r6:ci/image-off-pr
Oct 3, 2026
Merged

MarcusSorealheis merged 1 commit into
TraceMachina:mainfrom
b7r6:ci/image-off-pr

Conversation

@b7r6

@b7r6 b7r6 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

What and why

The Create OCI image workflow builds, tests, and Trivy-scans the container image on every pull request at a ~90-minute cap. It is not a code-correctness gate, and the image is already built, scanned, and published on every merge to main. Drop the pull_request trigger (keep push: main, add workflow_dispatch) to take a ~90-minute lane off every PR.

How was this verified?

YAML-validated. The push: main publish path and the get-images-matrix → publish-image flow are unchanged; only the pull_request trigger is removed and workflow_dispatch added. Confirmed via the PR checks UI that this is not a required status check, so dropping its PR trigger does not block merges.

Risk

Low. PRs no longer get a pre-merge image build/scan; image build breakage or newly-disclosed image CVEs are caught on merge to main (and on-demand via workflow_dispatch) rather than per-PR. No code build/test lane is affected, and there are no source, config, or wire-format changes.

AI assistance

An agent (Claude Code) drafted this change and description; I reviewed every line and validated the YAML myself.

The Create OCI image workflow is a ~90-min build/test/Trivy-scan that is
not a code-correctness gate; the image is already built, scanned, and
published on every merge to main. Drop the pull_request trigger (keep
push:main, add workflow_dispatch) to take it off the per-PR path.
@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Oct 3, 2026 8:53pm UTC
nativelink-aidm Ready Ready Preview Oct 3, 2026 8:53pm UTC

Request Review

@MarcusSorealheis MarcusSorealheis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcusSorealheis
MarcusSorealheis merged commit bb3ead5 into TraceMachina:main Oct 3, 2026
38 checks passed
@b7r6
b7r6 deleted the ci/image-off-pr branch October 15, 2026 11:54
b7r6 added a commit to b7r6/nativelink that referenced this pull request Oct 21, 2026
Draft PRs run the per-PR heavy matrix on every push even though nobody
gates a draft on green checks. After TraceMachina#2877, TraceMachina#2879 and TraceMachina#2880 moved Bazel
Native, Cargo Native, coverage, the OCI image and the integration lanes
off pull_request, the per-PR heavy set is: Bazel Dev, Installation and
the rbe-toolchain matrix (nix.yaml), the LRE lanes (lre.yaml) and asan
(sanitizers.yaml). Gate those jobs on the PR not being a draft and add
ready_for_review to the pull_request trigger types so the full set fires
the moment a draft is promoted. In nix.yaml the guard is ANDed with the
existing nightly skip; the rbe matrix follows generate-rbe-commands via
`needs:`. Fast advisory lanes (vale, pre-commit, docs-lint,
pr-template-check) keep running on drafts on purpose.

Push, schedule and workflow_dispatch behavior is unchanged: the guard
passes for every non-PR event.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

2 active deployments
Preview – nativelink — 2d4cfc8f Deployed Oct 3, 2026 by vercel[bot]
Preview – nativelink-aidm — 2d4cfc8f Deployed Oct 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants