Repository navigation
ci: build the OCI image on merge-to-main, not on every PR - #2879
Merged
Merged
Conversation
The Create OCI image workflow is a ~90-min build/test/Trivy-scan that is not a code-correctness gate; the image is already built, scanned, and published on every merge to main. Drop the pull_request trigger (keep push:main, add workflow_dispatch) to take it off the per-PR path.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
b7r6
added a commit
to b7r6/nativelink
that referenced
this pull request
Oct 21, 2026
Draft PRs run the per-PR heavy matrix on every push even though nobody gates a draft on green checks. After TraceMachina#2877, TraceMachina#2879 and TraceMachina#2880 moved Bazel Native, Cargo Native, coverage, the OCI image and the integration lanes off pull_request, the per-PR heavy set is: Bazel Dev, Installation and the rbe-toolchain matrix (nix.yaml), the LRE lanes (lre.yaml) and asan (sanitizers.yaml). Gate those jobs on the PR not being a draft and add ready_for_review to the pull_request trigger types so the full set fires the moment a draft is promoted. In nix.yaml the guard is ANDed with the existing nightly skip; the rbe matrix follows generate-rbe-commands via `needs:`. Fast advisory lanes (vale, pre-commit, docs-lint, pr-template-check) keep running on drafts on purpose. Push, schedule and workflow_dispatch behavior is unchanged: the guard passes for every non-PR event. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The
Create OCI imageworkflow builds, tests, and Trivy-scans the container image on every pull request at a ~90-minute cap. It is not a code-correctness gate, and the image is already built, scanned, and published on every merge tomain. Drop thepull_requesttrigger (keeppush: main, addworkflow_dispatch) to take a ~90-minute lane off every PR.How was this verified?
YAML-validated. The
push: mainpublish path and theget-images-matrix→publish-imageflow are unchanged; only thepull_requesttrigger is removed andworkflow_dispatchadded. Confirmed via the PR checks UI that this is not a required status check, so dropping its PR trigger does not block merges.Risk
Low. PRs no longer get a pre-merge image build/scan; image build breakage or newly-disclosed image CVEs are caught on merge to
main(and on-demand viaworkflow_dispatch) rather than per-PR. No code build/test lane is affected, and there are no source, config, or wire-format changes.AI assistance
An agent (Claude Code) drafted this change and description; I reviewed every line and validated the YAML myself.