Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
b7r6
force-pushed
the
ci/bazel-retry-testing
branch
from
October 14, 2026 17:40
d00bb2a to
703f346
Compare
b7r6
force-pushed
the
ci/bazel-retry-testing
branch
from
October 15, 2026 11:19
703f346 to
bf60d57
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
b7r6
force-pushed
the
ci/bazel-retry-testing
branch
from
October 21, 2026 17:45
bf60d57 to
06abaf3
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
This follows up #2897. It gives
tools/bazel-retry.sha behavioural test harness, so the retry and no-retry rules are pinned by tests instead of by reading the regex. A second copy of this wrapper lives in an internal repo, and pinning this copy's behaviour gives the eventual reconciliation a fixed point.It also removes an
execfrom the wrapper. Inside the pipeline it only ever replaced the subshell, so behaviour is unchanged, but it reads like a bug to anyone auditing the retry flow.How was this verified?
Run
python3 tools/test-bazel-retry.py. It uses only the standard library and doesn't need Bazel. It runs the real script with a fakebazelonPATH, which follows a scripted plan for each attempt and logs every invocation. Each test checks both the exit code and exactly how many attempts the wrapper made. The cases are:UNAVAILABLE:)The attempt-count checks fail against a wrapper that retries unconditionally. The suite takes about 30 s, because the real 5 s and 10 s backoffs run.
Risk
Low. The wrapper change only removes a redundant
execfrom a CI-only script. The test file is new and nothing runs it automatically yet. I'm happy to wire it into a workflow here or in a follow-up.AI assistance
Claude drafted the harness and the
execremoval under my direction.