Repository navigation
Worker match logging off by default, and listing only queued and executing operations when on - #2924
Merged
Merged
Conversation
…uting operations when on
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
corcillo
approved these changes
Oct 12, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
worker_match_logging_interval_sdefaults to 10 s, and each log pass runsfilter_operationswith the default filter: every operation in the store, completed ones included, on every scheduler replica. On a customer's five-replica install with the scheduler state in Redis that is a full index read every 10 s per replica, on a Redis master already at one CPU and refusing writes at its memory ceiling, to produce a log line most operators never read.The default is now -1, disabled, with the cost spelled out next to the key, and when it is enabled the listing asks only for queued and executing operations, which is what "oldest actions in state" is about.
How was this verified?
The scheduler and config crates pass all tests and clippy with
-D warnings. The tests that set the interval explicitly (-2,1) still exercise the validation and the logging path.Risk
Installs that relied on the default 10 s log lose it until they set the key. The log content is unchanged when enabled, apart from no longer naming completed operations.
AI assistance
An agent drafted the change and I reviewed every line.