Skip to content

Worker match logging off by default, and listing only queued and executing operations when on - #2924

Merged
amankrx merged 1 commit into
TraceMachina:mainfrom
amankrx:fix/matcher-redis-load
Oct 12, 2026
Merged

amankrx merged 1 commit into
TraceMachina:mainfrom
amankrx:fix/matcher-redis-load

Conversation

@amankrx

@amankrx amankrx commented Oct 12, 2026

Copy link
Copy Markdown
Member

What and why

worker_match_logging_interval_s defaults to 10 s, and each log pass runs filter_operations with the default filter: every operation in the store, completed ones included, on every scheduler replica. On a customer's five-replica install with the scheduler state in Redis that is a full index read every 10 s per replica, on a Redis master already at one CPU and refusing writes at its memory ceiling, to produce a log line most operators never read.

The default is now -1, disabled, with the cost spelled out next to the key, and when it is enabled the listing asks only for queued and executing operations, which is what "oldest actions in state" is about.

How was this verified?

The scheduler and config crates pass all tests and clippy with -D warnings. The tests that set the interval explicitly (-2, 1) still exercise the validation and the logging path.

Risk

Installs that relied on the default 10 s log lose it until they set the key. The log content is unchanged when enabled, apart from no longer naming completed operations.

AI assistance

An agent drafted the change and I reviewed every line.

@vercel

vercel Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Oct 12, 2026 12:14pm UTC
nativelink-aidm Ready Ready Preview Oct 12, 2026 12:14pm UTC

Request Review

@amankrx
amankrx merged commit b5bdf36 into TraceMachina:main Oct 12, 2026
47 of 56 checks passed

This branch was successfully deployed

2 active deployments
Preview – nativelink — 81a8c027 Deployed Oct 12, 2026 by vercel[bot]
Preview – nativelink-aidm — 81a8c027 Deployed Oct 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants