Repository navigation
Compare the webpki root store with assert_ne so pedantic Clippy passes - #3007
Merged
amankrx merged 2 commits intoOct 22, 2026
Merged
Conversation
…ts the non-empty guard.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
Member
|
Try to get this PR merged quickly as the CI is broken, and we need to merge the latest changes for a new release asap. |
amankrx
approved these changes
Oct 22, 2026
matdexir
marked this pull request as ready for review
October 22, 2026 10:15
Contributor
Author
|
hey @amankrx, should be ready to go, just waiting on the other jobs to finish |
palfrey
approved these changes
Oct 22, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The webpki-roots 1.0.10 bump added
tls_roots_exclude_distrusted_emsign_ecc_root, and its non-empty guard usedassert!(!webpki_roots::TLS_SERVER_ROOTS.is_empty()). Pedantic Clippy denies that asclippy::assert_is_empty, soasan / ubuntu-24.04in CI / Sanitizers failed while building//nativelink-store:integration_tests/azure_blob_store_test_teston main and on any branch that contains that commit. The guard is nowassert_ne!(webpki_roots::TLS_SERVER_ROOTS, []), which is the comparison Clippy asks for. It still fails if the store is empty, so a vacant root list cannot make the distrusted-root check pass without provingemSign ECC Root CA - G3was removed.How was this verified?
Not run locally. This machine has no Rust toolchain, and the failing job is the Linux nightly AddressSanitizer build. The rewrite is Clippy's suggested replacement for that lint, and
TrustAnchorimplementsPartialEqandDebug, whichassert_ne!needs. The AddressSanitizer job on this pull request is the check that the test target builds.Risk
Low. Test-only change, no runtime, config, or deployment behavior. If the comparison does not type-check, the same Clippy build fails again.
AI assistance
An agent wrote the change.