Skip to content

Compare the webpki root store with assert_ne so pedantic Clippy passes - #3007

Merged
amankrx merged 2 commits into
TraceMachina:mainfrom
matdexir:fix/webpki-roots-assert-is-empty
Oct 22, 2026
Merged

amankrx merged 2 commits into
TraceMachina:mainfrom
matdexir:fix/webpki-roots-assert-is-empty

Conversation

@matdexir

@matdexir matdexir commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

What and why

The webpki-roots 1.0.10 bump added tls_roots_exclude_distrusted_emsign_ecc_root, and its non-empty guard used assert!(!webpki_roots::TLS_SERVER_ROOTS.is_empty()). Pedantic Clippy denies that as clippy::assert_is_empty, so asan / ubuntu-24.04 in CI / Sanitizers failed while building //nativelink-store:integration_tests/azure_blob_store_test_test on main and on any branch that contains that commit. The guard is now assert_ne!(webpki_roots::TLS_SERVER_ROOTS, []), which is the comparison Clippy asks for. It still fails if the store is empty, so a vacant root list cannot make the distrusted-root check pass without proving emSign ECC Root CA - G3 was removed.

How was this verified?

Not run locally. This machine has no Rust toolchain, and the failing job is the Linux nightly AddressSanitizer build. The rewrite is Clippy's suggested replacement for that lint, and TrustAnchor implements PartialEq and Debug, which assert_ne! needs. The AddressSanitizer job on this pull request is the check that the test target builds.

Risk

Low. Test-only change, no runtime, config, or deployment behavior. If the comparison does not type-check, the same Clippy build fails again.

AI assistance

An agent wrote the change.

@vercel

vercel Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Oct 22, 2026 10:20am UTC
nativelink-aidm Ready Ready Preview Oct 22, 2026 10:20am UTC

Request Review

@github-actions

This comment has been minimized.

@amankrx

amankrx commented Oct 22, 2026

Copy link
Copy Markdown
Member

Try to get this PR merged quickly as the CI is broken, and we need to merge the latest changes for a new release asap.

@matdexir
matdexir marked this pull request as ready for review October 22, 2026 10:15
@matdexir

Copy link
Copy Markdown
Contributor Author

hey @amankrx, should be ready to go, just waiting on the other jobs to finish

@MarcusSorealheis MarcusSorealheis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This branch was successfully deployed

2 active deployments
Preview – nativelink — 738be052 Deployed Oct 22, 2026 by vercel[bot]
Preview – nativelink-aidm — 738be052 Deployed Oct 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants