Skip to content

ci: run AddressSanitizer and fuzzing nightly - #3029

Merged
MarcusSorealheis merged 6 commits into
mainfrom
nightly-asan-fuzz
Oct 23, 2026
Merged

MarcusSorealheis merged 6 commits into
mainfrom
nightly-asan-fuzz

Conversation

@matdexir

@matdexir matdexir commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

What and why

AddressSanitizer and ClusterFuzzLite were running on pull requests. Both are expensive and neither gates merge, so ordinary pull requests now keep the Nix Bazel lane. These two still run at 07:00 UTC against main, when a release is published, when someone starts the workflow by hand, and on a release pull request. A release pull request is one whose head branch is release/vX.Y.Z (as in #3028) or whose title is Release NativeLink vX.Y.Z.

How was this verified?

Compared the workflow triggers with the existing nightly lanes (Cargo Native, Coverage) and with the signed-artifacts workflow, which also uses release: types: [published]. Release pull requests follow the release/vX.Y.Z branch used by #3028 and by Release / Prepare PR. Confirmed the branch ruleset does not require the asan / ubuntu-24.04 or Fuzz checks. Did not dispatch either workflow; the schedule and the release trigger only start once this is on main. This pull request itself is not a release pull request, so those two jobs should skip here.

Risk

Low. A sanitizer or fuzzer failure shows up the next morning, on a release pull request, on the next published release, or on a manual run, rather than on an ordinary pull request. A release pull request and a published release stay on the read-only cache key. A manual run of a branch other than main does too. The nightly run of main still uses the write key.

AI assistance

An agent wrote the workflow edits. I reviewed the approach and asked for this pull request.

@matdexir
matdexir temporarily deployed to cluster-ci-benchmark October 23, 2026 13:40 — with GitHub Actions Inactive
@matdexir
matdexir temporarily deployed to cluster-ci-benchmark October 23, 2026 13:40 — with GitHub Actions Inactive
@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Oct 23, 2026 9:39pm UTC
nativelink-aidm Ready Ready Preview Oct 23, 2026 9:39pm UTC

Request Review

@matdexir

matdexir commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor Author

the CI/Nix/Build shared nix package is unrelated to this change and it's flaky, i shall try to make it consistent.

Both lanes are expensive and do not gate merge. Pull requests keep the Nix Bazel lane.
The retained client returns EPERM when a sandboxed build chmods that source, so uncached package builds fail before compile.
A published release should get the same sanitizer and fuzz signal as the nightly run. The tag stays on the read-only cache key.
A release pull request, such as release/v1.8.1, should get the same sanitizer and fuzz signal as a published release. Ordinary pull requests stay on the Nix Bazel lane.

@MarcusSorealheis MarcusSorealheis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcusSorealheis
MarcusSorealheis merged commit e4b5314 into main Oct 23, 2026
28 checks passed
@MarcusSorealheis
MarcusSorealheis deleted the nightly-asan-fuzz branch October 23, 2026 21:54
@rajputdivyanshu81 rajputdivyanshu81 mentioned this pull request Oct 31, 2026
1 of 4 tasks

This branch was successfully deployed

2 active and 1 inactive deployments
Preview – nativelink — c1b91e79 Deployed Oct 23, 2026 by vercel[bot]
Preview – nativelink-aidm — c1b91e79 Deployed Oct 23, 2026 by vercel[bot]
cluster-ci-benchmark — c1b91e79 Deployed Oct 23, 2026 by MarcusSorealheis via Build shared Nix package #9297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants