Repository navigation
Report action phases, transfer bytes and why an attempt ended in origin events - #3040
Merged
amankrx merged 5 commits intoOct 26, 2026
Merged
Conversation
…d in origin events
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
corcillo
reviewed
Oct 25, 2026
corcillo
reviewed
Oct 25, 2026
corcillo
reviewed
Oct 25, 2026
corcillo
reviewed
Oct 25, 2026
corcillo
reviewed
Oct 25, 2026
corcillo
reviewed
Oct 25, 2026
corcillo
requested changes
Oct 25, 2026
…, with input-fetch timeout and lost-result reasons
corcillo
reviewed
Oct 25, 2026
corcillo
reviewed
Oct 25, 2026
… timeout only when the operation was actually timed out
corcillo
approved these changes
Oct 26, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Origin events now say how long an action spent fetching inputs and uploading outputs, how many bytes it moved and how many the worker already held, and why the scheduler ended an attempt without keeping its result. The telemetry UI needs these to tell queue time from transfer time and to explain internal retries.
How was this verified?
New tests cover the input byte counts (all fetched, then all cached on a second fetch), the phase durations read from the result metadata, and the attempt-ended event for a timeout and for a lost worker. The lost-worker test hung until eviction published the event too. The generated code matches
bazel run //nativelink-proto:update_protos.Risk
Additive proto fields and one new origin event type (
0x020D); consumers that do not know them skip them. The attempt-ended event usestry_sendunder the scheduler lock, so a full publisher queue drops it rather than stalling scheduling.AI assistance
An agent drafted the change and I reviewed every line.