Skip to content

Override MSAL Node to 7.1.0 in the Azurite test runner - #3048

Merged
MarcusSorealheis merged 3 commits into
mainfrom
fix-msal-node-advisory
Oct 26, 2026
Merged

MarcusSorealheis merged 3 commits into
mainfrom
fix-msal-node-advisory

Conversation

@MarcusSorealheis

@MarcusSorealheis MarcusSorealheis commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

What and why

OSV reports GHSA-xcx6-jx8p-x3h5 (CVE-2026-109461) against this repository. @azure/msal-node before 7.1.0 trusted the cloud host names in an authorization code payload, so a crafted payload could send a confidential client's token request to an attacker-controlled endpoint. 7.1.0 sanitizes that payload and rejects instance-aware confidential clients.

It reaches only the Azure store's test runner: Azurite pulls in @azure/identity through applicationinsights, @azure/monitor-opentelemetry and tedious, and identity pulls in @azure/msal-node 5.6.0. Bumping identity cannot reach the fix, because its newest release (4.14.0) still asks for ^6.0.0. The runner's package.json already overrides four other transitive packages for advisories, so this adds "@azure/msal-node": "^7.1.0" there, which resolves to 7.1.1 (and its own @azure/msal-common 16.14.3).

How was this verified?

  • Added a test to dependency-security.test.cjs that loads MSAL Node the way @azure/identity resolves it and constructs a ConfidentialClientApplication with instanceAware: true. The 7.1.0 fix makes that throw unsupported_cca_instance_aware.
  • Against the current lock (msal-node 5.6.0) the test fails with "Missing expected exception". With the override it passes, and so do the other eight tests: 9 of 9.
  • bun install --frozen-lockfile succeeds on the updated lock, which is what the setup action runs. The lock diff is the override plus the two MSAL packages, nothing else.
  • @azure/identity still loads and constructs a ClientSecretCredential on top of msal-node 7.1.1.
  • cargo test -p nativelink-store --test azurite_store_test against this install: 3 passed, 2 ignored. The ignored ones are manual tools; one needs a live Azurite on a fixed port.

The test checks a behaviour shipped with the fix, not the payload sanitization itself. Exercising that needs a token endpoint for MSAL to call, which the runner has no reason to stand up.

Risk

Low. The package is only reached by the Azurite emulator used in tests, and nothing in that path does an interactive or authorization-code sign-in. The override does jump two majors past what @azure/identity declares. The breaking changes in msal-node 6 and 7 are both in acquireTokenInteractive (the loopbackClient option and responseMode), which Azurite never calls. If the jump did break something, the Azurite store tests would be the first to notice.

AI assistance

An agent (Claude Code) traced the dependency path, wrote the override and the test, and ran the checks above; I reviewed the change.

🤖 Generated with Claude Code

GHSA-xcx6-jx8p-x3h5 affects @azure/msal-node from 5.0.0-beta.0 up to 7.1.0.
Azurite reaches it through @azure/identity, whose newest release still asks
for ^6.0.0, so the fix arrives through an override like the runner's others.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Oct 26, 2026 2:02am UTC
nativelink-aidm Ready Ready Preview Oct 26, 2026 2:02am UTC

Request Review

@MarcusSorealheis
MarcusSorealheis merged commit 7e55aeb into main Oct 26, 2026
24 of 26 checks passed
@MarcusSorealheis
MarcusSorealheis deleted the fix-msal-node-advisory branch October 26, 2026 02:08

This branch was successfully deployed

2 active and 1 inactive deployments
cluster-ci-benchmark — 819b96e9 Deployed Oct 26, 2026 by MarcusSorealheis via Build shared Nix package #9324
Preview – nativelink — 819b96e9 Deployed Oct 26, 2026 by vercel[bot]
Preview – nativelink-aidm — 819b96e9 Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants