Repository navigation
Override MSAL Node to 7.1.0 in the Azurite test runner - #3048
Merged
Merged
Conversation
GHSA-xcx6-jx8p-x3h5 affects @azure/msal-node from 5.0.0-beta.0 up to 7.1.0. Azurite reaches it through @azure/identity, whose newest release still asks for ^6.0.0, so the fix arrives through an override like the runner's others. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
October 25, 2026 22:42 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
October 26, 2026 00:54 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
October 26, 2026 00:54 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
October 26, 2026 02:02 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
October 26, 2026 02:02 — with
GitHub Actions
Inactive
corcillo
approved these changes
Oct 26, 2026
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
October 26, 2026 02:08 — with
GitHub Actions
Inactive
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
OSV reports GHSA-xcx6-jx8p-x3h5 (CVE-2026-109461) against this repository.
@azure/msal-nodebefore 7.1.0 trusted the cloud host names in an authorization code payload, so a crafted payload could send a confidential client's token request to an attacker-controlled endpoint. 7.1.0 sanitizes that payload and rejects instance-aware confidential clients.It reaches only the Azure store's test runner: Azurite pulls in
@azure/identitythroughapplicationinsights,@azure/monitor-opentelemetryandtedious, and identity pulls in@azure/msal-node5.6.0. Bumping identity cannot reach the fix, because its newest release (4.14.0) still asks for^6.0.0. The runner'spackage.jsonalready overrides four other transitive packages for advisories, so this adds"@azure/msal-node": "^7.1.0"there, which resolves to 7.1.1 (and its own@azure/msal-common16.14.3).How was this verified?
dependency-security.test.cjsthat loads MSAL Node the way@azure/identityresolves it and constructs aConfidentialClientApplicationwithinstanceAware: true. The 7.1.0 fix makes that throwunsupported_cca_instance_aware.bun install --frozen-lockfilesucceeds on the updated lock, which is what the setup action runs. The lock diff is the override plus the two MSAL packages, nothing else.@azure/identitystill loads and constructs aClientSecretCredentialon top of msal-node 7.1.1.cargo test -p nativelink-store --test azurite_store_testagainst this install: 3 passed, 2 ignored. The ignored ones are manual tools; one needs a live Azurite on a fixed port.The test checks a behaviour shipped with the fix, not the payload sanitization itself. Exercising that needs a token endpoint for MSAL to call, which the runner has no reason to stand up.
Risk
Low. The package is only reached by the Azurite emulator used in tests, and nothing in that path does an interactive or authorization-code sign-in. The override does jump two majors past what
@azure/identitydeclares. The breaking changes in msal-node 6 and 7 are both inacquireTokenInteractive(theloopbackClientoption andresponseMode), which Azurite never calls. If the jump did break something, the Azurite store tests would be the first to notice.AI assistance
An agent (Claude Code) traced the dependency path, wrote the override and the test, and ran the checks above; I reviewed the change.
🤖 Generated with Claude Code