Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
palfrey
temporarily deployed
to
cluster-ci-aws
November 20, 2026 15:37 — with
GitHub Actions
Inactive
palfrey
had a problem deploying
to
cluster-ci-aws
November 20, 2026 15:37 — with
GitHub Actions
Failure
palfrey
temporarily deployed
to
cluster-ci-aws
November 20, 2026 15:53 — with
GitHub Actions
Inactive
palfrey
marked this pull request as ready for review
November 20, 2026 16:03
palfrey
temporarily deployed
to
cluster-ci-aws
November 20, 2026 18:51 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-aws
November 20, 2026 18:51 — with
GitHub Actions
Inactive
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
CI / Cargo fails continually, so we need to fix the broken tests there.
pressure_kill_reaches_a_job_control_groupandstraggler_sweep_reaches_an_orphaned_job_control_groupassume they can run a process and then check if it got correctly killed off by checking it's pid. Except the pids we were getting out of them were things like2which seems weirdly small. The reason for this was that they were running in new namespaces, and after they get killed off the tests were trying to read effectively the wrong pid.This PR disables namespaces for those tests :)
How was this verified?
Local tests under Cargo; CI tests https://github.com/TraceMachina/nativelink/actions/runs/44796781162. Note the Windows tests are still broken, but that's a different problem. This PR just fixes the Ubuntu cases.
Risk
Low. The one risky case is if those job control tests fail under namespaces, but work otherwise. Testing that is hard, because we need to get the external pid for a job, not it's in-namespace pid, which I think you deliberately can't get from inside the namespace.
AI assistance
None