Skip to content

Disable namespaces for job control tests - #3247

Open
palfrey wants to merge 3 commits into
mainfrom
job-control-group-issues
Open

palfrey wants to merge 3 commits into
mainfrom
job-control-group-issues

Conversation

@palfrey

@palfrey palfrey commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

What and why

CI / Cargo fails continually, so we need to fix the broken tests there.

pressure_kill_reaches_a_job_control_group and straggler_sweep_reaches_an_orphaned_job_control_group assume they can run a process and then check if it got correctly killed off by checking it's pid. Except the pids we were getting out of them were things like 2 which seems weirdly small. The reason for this was that they were running in new namespaces, and after they get killed off the tests were trying to read effectively the wrong pid.

This PR disables namespaces for those tests :)

How was this verified?

Local tests under Cargo; CI tests https://github.com/TraceMachina/nativelink/actions/runs/44796781162. Note the Windows tests are still broken, but that's a different problem. This PR just fixes the Ubuntu cases.

Risk

Low. The one risky case is if those job control tests fail under namespaces, but work otherwise. Testing that is hard, because we need to get the external pid for a job, not it's in-namespace pid, which I think you deliberately can't get from inside the namespace.

AI assistance

None

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Nov 20, 2026 6:52pm UTC
nativelink-aidm Ready Ready Preview Nov 20, 2026 6:52pm UTC

Request Review

@github-actions

This comment has been minimized.

@palfrey palfrey changed the title Add extra logging to job control group tests Disable namespaces for job control tests Nov 20, 2026
@palfrey
palfrey marked this pull request as ready for review November 20, 2026 16:03

This branch was successfully deployed

2 active and 1 inactive deployments
Preview – nativelink — 3eab894e Deployed Nov 20, 2026 by vercel[bot]
Preview – nativelink-aidm — 3eab894e Deployed Nov 20, 2026 by vercel[bot]
cluster-ci-aws — 3eab894e Deployed Nov 20, 2026 by palfrey via NativeLink / Linux #995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant