Repository navigation
Scheduler: a worker can name itself, and a reconnect under that name ends its earlier connection - #3260
Open
amankrx wants to merge 1 commit into
Open
Scheduler: a worker can name itself, and a reconnect under that name ends its earlier connection#3260amankrx wants to merge 1 commit into
amankrx wants to merge 1 commit into
Conversation
…ends its earlier connection
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ashishsonamm
approved these changes
Nov 22, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
First step toward a worker keeping its running actions across a lost scheduler connection. Today the scheduler names every connection afresh, so a reconnected worker is a stranger and its actions run again. Nothing sends a name yet; the worker side comes later.
ConnectWorkerRequest.worker_id: the scheduler uses it as given, at most 256 bytes with no spaces or control characters. Empty, as from today's workers, keeps today's naming.How was this verified?
Service tests: a named worker is registered under its name; bad names are refused; a reconnect requeues the old connection's action and keeps the worker when the old stream ends, which fails without the stamp check. Scheduler, service, simulator and worker suites pass.
Risk
None for today's workers, which send no name. The protocol change is one optional field.
AI assistance
An agent drafted the change and I reviewed every line.