Skip to content

Draft work on CustomError - #907

Closed
ItsShadowl wants to merge 1 commit into
TrueFiEng:masterfrom
ItsShadowl:patch-1
Closed

ItsShadowl wants to merge 1 commit into
TrueFiEng:masterfrom
ItsShadowl:patch-1

Conversation

@ItsShadowl

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-bot Bot commented Jul 29, 2022

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 386f5cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ItsShadowl ItsShadowl left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be completing the draft before submitting

@rzadp

rzadp commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

@ItsShadowl We have implementation of CustomErrors, working with Hardhat - please take a look into the tests in action here https://github.com/TrueFiEng/Waffle/blob/12c2d7209a310202e8b03862972a88735e5803a0/waffle-hardhat/test/reverted.test.ts#L37

@ItsShadowl

Copy link
Copy Markdown
Contributor Author

@ItsShadowl We have implementation of CustomErrors, working with Hardhat - please take a look into the tests in action here https://github.com/TrueFiEng/Waffle/blob/12c2d7209a310202e8b03862972a88735e5803a0/waffle-hardhat/test/reverted.test.ts#L37

The error args and errorName can't be pulled from UseDapp

@rzadp

rzadp commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

@ItsShadowl Ah sorry I confused UseDapp with Waffle because I switch from one to another during the day 🤦‍♂️

@ItsShadowl

Copy link
Copy Markdown
Contributor Author

@ItsShadowl Ah sorry I confused UseDapp with Waffle because I switch from one to another during the day 🤦‍♂️

I did notice that, LOL

@pawelpolak2

Copy link
Copy Markdown
Contributor

Hey, we'll add it to our roadmap. Closing for now. Please feel free to reopen if needed. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants