Repository navigation
Correct the g/g, percent and nautical mile conversion factors - #1050
Open
arpitjain099 wants to merge 4 commits into
Open
arpitjain099 wants to merge 4 commits into
arpitjain099 wants to merge 4 commits into
Conversation
The g/g rows in TADAPriorityCharConvertRef.csv carry the same values as the pg/g rows, which puts them 1e12 away from what the rest of the mass per mass family implies under the file's own 1 kg = 1 L convention. The percent rows carry those values too and are 1e10 out. Separately nmi to m reads 1.83E+03 where the international nautical mile is 1852 m; the nmi rows for ft and in already imply that. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
hillarymarler
self-requested a review
October 14, 2026 13:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TADAPriorityCharConvertRef.csvholds 22 mass-per-mass rows targeting ug/L and mg/L. Twenty of them agree exactly with the file's own 1 kg = 1 L convention, and the twog/grows do not:Both shipped values are byte-identical to the
pg/grows, which looks like a copy rather than a decision, and they are 1e12 off. The two%rows carry the same pair and are 1e10 off: one percent by mass is 0.01 g/g, so 1e+07 to ug/L and 1e+04 to mg/L.Separately,
nmitomreads 1.83E+03. The nautical mile is 1852 m exactly, and this file's ownnmirows for ft and in both imply 1852, so 1.8520E+03.Data-only change. I could not run
devtools::checkhere: the package needs sf and arcgislayers, which need GDAL, so the evidence is the table against itself rather than a package run.