Skip to content

Correct the g/g, percent and nautical mile conversion factors - #1050

Open
arpitjain099 wants to merge 4 commits into
USEPA:developfrom
arpitjain099:fix/unit-conversion-constants
Open

arpitjain099 wants to merge 4 commits into
USEPA:developfrom
arpitjain099:fix/unit-conversion-constants

Conversation

@arpitjain099

Copy link
Copy Markdown

TADAPriorityCharConvertRef.csv holds 22 mass-per-mass rows targeting ug/L and mg/L. Twenty of them agree exactly with the file's own 1 kg = 1 L convention, and the two g/g rows do not:

unit    target   shipped     implied by the siblings
mg/kg   ug/L     1.0000e+03  1.0000e+03
ug/g    ug/L     1.0000e+03  1.0000e+03
g/kg    ug/L     1.0000e+06  1.0000e+06
g/g     ug/L     1.0000e-03  1.0000e+09
g/g     mg/L     1.0000e-06  1.0000e+06

Both shipped values are byte-identical to the pg/g rows, which looks like a copy rather than a decision, and they are 1e12 off. The two % rows carry the same pair and are 1e10 off: one percent by mass is 0.01 g/g, so 1e+07 to ug/L and 1e+04 to mg/L.

Separately, nmi to m reads 1.83E+03. The nautical mile is 1852 m exactly, and this file's own nmi rows for ft and in both imply 1852, so 1.8520E+03.

Data-only change. I could not run devtools::check here: the package needs sf and arcgislayers, which need GDAL, so the evidence is the table against itself rather than a package run.

arpitjain099 and others added 2 commits September 20, 2026 19:37
The g/g rows in TADAPriorityCharConvertRef.csv carry the same values as the
pg/g rows, which puts them 1e12 away from what the rest of the mass per mass
family implies under the file's own 1 kg = 1 L convention. The percent rows
carry those values too and are 1e10 out. Separately nmi to m reads 1.83E+03
where the international nautical mile is 1852 m; the nmi rows for ft and in
already imply that.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
@hillarymarler
hillarymarler self-requested a review October 14, 2026 13:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants