Get rid of VerEx() and "from" import #23

Activity

1. jehna commented on Mar 30, 2017

   

   jehna

   on Mar 30, 2017

   Contributor

   More actions

   The VerEx format is originally copied from Javascript implementation, which originates from the Javascript's native RegRxp object writing format.

   I agree lowercase format would look more pythonic.

   👍React with 👍2Reacted by Victor Engmark and HorridModz
2. jehna commented on Mar 30, 2017

   

   jehna

   on Mar 30, 2017

   Contributor

   More actions

   On the other hand, you could see verbalexpressions as a "regular expression builder", and thus imitating a string builder.

   In this case the Python implementation should be something like:

   ve = new VerEx()
   ve.first('http://')
   ve.maybe('www.')
   ve.then('google.com')

   ...like compared to e.g. Java's StringBuilder

   ❤️React with ❤️1Reacted by HorridModz
3. Mahi commented on Mar 30, 2017

   

   Mahi

   on Mar 30, 2017

   Last edited by Mahi

   Author

   More actions

   Maybe it's just me, but I find the string building way very unpythonic. It just makes sense to have this instead:

   ve = VerEx()
   ve = ve.first('http://')
   ve = ve.maybe('www.')
   ve = ve.then('google.com')
   

   Yes, it's longer, but also more clear and explicit. This is also how SQLAlchemy works -- a very similar library but for building SQL instead of regex.

   Also, not supporting the string builder would allow something like this:

   generic_ve = VerEx().first('http://').maybe('www.').then('example.com/')
   videos_ve = generic_ve.then('videos')
   images_ve = generic_ve.then('images')
   documents_ve = generic_ve.then('documents')
   

   With the string building example of yours, documents_ve would end up being videosimagesdocuments