Repository navigation
Conversation
Add as section in the beginning of Concurrency.md which summarizes the meaning of the various combinations of async lift/lower canonopts with the async function type.
lukewagner
approved these changes
Nov 4, 2026
lukewagner
left a comment
lukewagner
left a comment
Member
There was a problem hiding this comment.
Great idea, thanks! Looks good with these nits:
Co-authored-by: Luke Wagner <mail@lukewagner.name>
Co-authored-by: Luke Wagner <mail@lukewagner.name>
Co-authored-by: Luke Wagner <mail@lukewagner.name>
Co-authored-by: Luke Wagner <mail@lukewagner.name>
Co-authored-by: Luke Wagner <mail@lukewagner.name>
Co-authored-by: Luke Wagner <mail@lukewagner.name>
lukewagner
approved these changes
Nov 6, 2026
|
|
||
| | Component function type | Lift canonical option | Valid? | Effect of callee blocking | Holds instances's exclusive lock? | Can call while instance lock held? | | ||
| | ----------------------- | --------------------- | ------ | ------------------------- | --------------------------------- | ---------------------------------- | | ||
| | `sync` | sync | ✅ | Switch to another ready thread in the component instance, trap if there is none | No, but only threads in the same instance and their recursive calls can run until callee returns | Yes | |
Member
There was a problem hiding this comment.
Since there's also not sync on types, could you also remove backticks in the first column too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add as section in the beginning of Concurrency.md which summarizes the meaning of the various combinations of async lift/lower canonopts with the async function type.