Repository navigation
Config lib overwrites global settings when using lists or sets #1916
Description
When using the config lib to store a list or set (using S{} or L{}) the global settings are overloaded after reloading an addon and modifying settings.
You can easily reproduce this issue with the Autojoin addon:
- Remove settings.xml if it already exists for Autojoin.
- Load Autojoin.
- Add to the whitelist with
//autojoin whitelist add xurion. The settings.xml file will look ok at this point. - Reload Autojoin.
- Add a second entry on to the whitelist.
The <global> in settings.xml will now be polluted with incorrect settings that will now be applied to all other characters.
Activity
RubenatorX commentedon Aug 8, 2020
this is not a problem with the config lib, Its a problem with the addon. It needs to be re-loading settings on login, and its not doing that.
RubenatorX commentedon Aug 8, 2020
Actually I'm wrong, it definitely decides to add some of the settings to global, not sure why will chat with someone about it.