You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
UserControllerFactory over-eager loading of all forms from factories #643
seems really un-necessary to create+inject a change password form, register form, etc when someone is just logging in, same goes for other controller actions
changed the title [-]eager loading of all forms from factories into controller when pulled from service manager[/-][+]eager loading all forms from factories into controller when pulled from service manager[/+]on Jun 30, 2016
changed the title [-]eager loading all forms from factories into controller when pulled from service manager[/-][+]UserControllerFactory eager loading all forms from factories[/+]on Jun 30, 2016
changed the title [-]UserControllerFactory eager loading all forms from factories[/-][+]UserControllerFactory over-eager loading of all forms from factories[/+]on Jun 30, 2016
Creating (injecting) the login form in UserControllerFactory causes all flash messages to be lost! This means that when a user changes their password or e-mail address the feedback message will not be displayed.
The UserController::setLoginForm method changes the namespace of the flashMessenger causing all previous messages to be lost.
Remove all the form creation methods and save the overhead of creating forms that will not be needed.
Activity
[-]eager loading of all forms from factories into controller when pulled from service manager[/-][+]eager loading all forms from factories into controller when pulled from service manager[/+][-]eager loading all forms from factories into controller when pulled from service manager[/-][+]UserControllerFactory eager loading all forms from factories[/+][-]UserControllerFactory eager loading all forms from factories[/-][+]UserControllerFactory over-eager loading of all forms from factories[/+]nclundsten commentedon Jun 30, 2016
if its determined that the forms should continue to be injected in the controller factory, then we could at least use lazy services -- https://framework.zend.com/manual/2.4/en/modules/zend.service-manager.lazy-services.html
hurnell commentedon Nov 7, 2016
Creating (injecting) the login form in UserControllerFactory causes all flash messages to be lost! This means that when a user changes their password or e-mail address the feedback message will not be displayed.
The UserController::setLoginForm method changes the namespace of the flashMessenger causing all previous messages to be lost.
Remove all the form creation methods and save the overhead of creating forms that will not be needed.