Skip to content

Upgrade to rubocop 0.51.0 - #55

Merged
mpotter merged 5 commits into
masterfrom
rubocop-0.51.0
Oct 24, 2017
Merged

mpotter merged 5 commits into
masterfrom
rubocop-0.51.0

Conversation

@mpotter

@mpotter mpotter commented Oct 21, 2017 •

Copy link
Copy Markdown
Contributor

Updates minimum rubocop version from 0.49.1 to 0.51.0.

  • Set rubocop minimum version to 0.51.0
  • Remove deprecated Style/Encoding rules
  • Update to new Style rules that now use Naming prefix
  • Remove unnecessary utf-8 encoding comment
  • Adhere to gemspec alphabetical order rule

Details in the rubocop CHANGELOG.

@mpotter
mpotter requested a review from dennmart October 21, 2017 18:40
@mpotter mpotter changed the title Upgrade to Rubocop 0.51.0 Upgrade to rubocop 0.51.0 Oct 21, 2017
@brandonweiss

Copy link
Copy Markdown

@mpotter FYI, by copy-pasting the changelog you just notified every single person referenced in the changelog.

@mpotter

mpotter commented Oct 22, 2017

Copy link
Copy Markdown
Contributor Author

@brandonweiss Argh! I just assumed those links were to the diffs. That's unfortunate (great way to spam, though). Apologies.

@brandonweiss

Copy link
Copy Markdown

@mpotter No worries!

@dennmart dennmart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpotter Everything looks okay here! 😸

@mpotter
mpotter merged commit 16b7966 into master Oct 24, 2017
@mpotter
mpotter deleted the rubocop-0.51.0 branch October 24, 2017 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants