Repository navigation
Read npm licenses from the selected release - #211
Open
codewithfourtix wants to merge 1 commit into
Open
codewithfourtix wants to merge 1 commit into
codewithfourtix wants to merge 1 commit into
Conversation
Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
k-charansai
added a commit
to k-charansai/fetchcode
that referenced
this pull request
Nov 6, 2026
In get_npm_data_from_purl, declared_license was unconditionally set to the
top-level registry document's license, causing older or re-licensed package
versions to incorrectly inherit the package-level license.
Read declared_license from version.get('license') first, falling back to
the top-level license when absent or null. Add regression test covering
per-version license resolution and fallback behavior.
Closes aboutcode-org#211
Signed-off-by: k-charansai <kcharansai052@gmail.com>
k-charansai
added a commit
to k-charansai/fetchcode
that referenced
this pull request
Nov 6, 2026
In get_npm_data_from_purl, declared_license was unconditionally set to the
top-level registry document's license, causing older or re-licensed package
versions to incorrectly inherit the package-level license.
Read declared_license from version.get('license') first, falling back to
the top-level license when absent or null. Add regression test covering
per-version license resolution and fallback behavior.
Closes aboutcode-org#211
Signed-off-by: k-charansai <kcharansai052@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older npm releases currently inherit the registry document's top-level license, even when their own metadata specifies another license. Prefer the selected release's license, keeping the existing fallback when it is absent.
Adds a regression with releases under different licenses.