Repository navigation
[C++] Reject a numInGroup or var data length that does not fit its wire field in the OTF encoder - #1159
Open
slachiewicz wants to merge 2 commits into
Open
[C++] Reject a numInGroup or var data length that does not fit its wire field in the OTF encoder#1159slachiewicz wants to merge 2 commits into
slachiewicz wants to merge 2 commits into
Conversation
slachiewicz
force-pushed
the
cpp-otf-encoder-count-length-range
branch
from
November 19, 2026 20:48
acce649 to
fa78aa5
Compare
…re field in the OTF encoder. putAsUInt narrows to the field width, so the count or length must be checked against the type range and schema maxValue first, otherwise the wire header disagrees with the entries or bytes that follow it.
slachiewicz
force-pushed
the
cpp-otf-encoder-count-length-range
branch
from
November 19, 2026 21:01
fa78aa5 to
a3db543
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OtfMessageEncoder wrote numInGroup and var data lengths through putAsUInt, which narrows them to the wire field, and then wrote every entry and byte. A count or length larger than the field could hold put a header on the wire that disagrees with what follows it, so a decoder reads the excess as later fields.
encodeGroups and encodeData now throw when the value exceeds the field's primitive range or the schema maxValue, the same upper bounds the generated encoders check with E109/E110.
Part of #969.
Verified: the three new OtfMessageEncoderTest cases fail on master and pass here; sbe-tool checkstyle and test, cppbuild and cppbuild --debug-build --sanitise-build pass.