Skip to content

[C++] Reject a numInGroup or var data length that does not fit its wire field in the OTF encoder - #1159

Open
slachiewicz wants to merge 2 commits into
aeron-io:masterfrom
slachiewicz:cpp-otf-encoder-count-length-range
Open

slachiewicz wants to merge 2 commits into
aeron-io:masterfrom
slachiewicz:cpp-otf-encoder-count-length-range

Conversation

@slachiewicz

Copy link
Copy Markdown
Contributor

OtfMessageEncoder wrote numInGroup and var data lengths through putAsUInt, which narrows them to the wire field, and then wrote every entry and byte. A count or length larger than the field could hold put a header on the wire that disagrees with what follows it, so a decoder reads the excess as later fields.

encodeGroups and encodeData now throw when the value exceeds the field's primitive range or the schema maxValue, the same upper bounds the generated encoders check with E109/E110.

Part of #969.

Verified: the three new OtfMessageEncoderTest cases fail on master and pass here; sbe-tool checkstyle and test, cppbuild and cppbuild --debug-build --sanitise-build pass.

…re field in the OTF encoder.

putAsUInt narrows to the field width, so the count or length must be
checked against the type range and schema maxValue first, otherwise the
wire header disagrees with the entries or bytes that follow it.
@slachiewicz
slachiewicz force-pushed the cpp-otf-encoder-count-length-range branch from fa78aa5 to a3db543 Compare November 19, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant