Skip to content

[Java] Reject generated file names that would leave the output directory - #1181

Open
slachiewicz wants to merge 1 commit into
aeron-io:masterfrom
slachiewicz:sbe-output-file-name-check
Open

slachiewicz wants to merge 1 commit into
aeron-io:masterfrom
slachiewicz:sbe-output-file-name-check

Conversation

@slachiewicz

Copy link
Copy Markdown
Contributor

Every output manager built the generated file as new File(outputDir, name + extension), with the name taken from the schema. The parser only warns about names that are not valid identifiers, and names read from a .sbeir file are not checked at all, so a message or type named ../../X made sbe-tool create or overwrite X.h, X.java, X.go, X.g.cs or x.rs outside sbe.output.dir.

createOutput in the C, C++, C#, Go struct, Go flyweight, Rust and Java output managers now throws IllegalArgumentException for a name that contains a path or drive separator, before any file is opened. Valid identifiers are unaffected.

Part of #969.

Verified: OutputFilesTest fails on master for all seven output managers (../../../../Escaped is written) and passes here; sbe-tool checkstyle, tests, verifyJavaIrCodecsInSync, sbe-samples check, runRustTests, cppbuild and gocode make pass.

…ory.

Schema names are only checked with warnings, so the output managers must not
join them onto the output directory as paths. Keep the check in createOutput.
@slachiewicz
slachiewicz force-pushed the sbe-output-file-name-check branch from 943dc1f to 874a010 Compare November 19, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant