Repository navigation
[Java] Reject generated file names that would leave the output directory - #1181
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
…ory. Schema names are only checked with warnings, so the output managers must not join them onto the output directory as paths. Keep the check in createOutput.
slachiewicz
force-pushed
the
sbe-output-file-name-check
branch
from
November 19, 2026 21:02
943dc1f to
874a010
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every output manager built the generated file as
new File(outputDir, name + extension), with the name taken from the schema. The parser only warns about names that are not valid identifiers, and names read from a .sbeir file are not checked at all, so a message or type named../../Xmade sbe-tool create or overwriteX.h,X.java,X.go,X.g.csorx.rsoutsidesbe.output.dir.createOutput in the C, C++, C#, Go struct, Go flyweight, Rust and Java output managers now throws IllegalArgumentException for a name that contains a path or drive separator, before any file is opened. Valid identifiers are unaffected.
Part of #969.
Verified: OutputFilesTest fails on master for all seven output managers (
../../../../Escapedis written) and passes here; sbe-tool checkstyle, tests, verifyJavaIrCodecsInSync, sbe-samples check, runRustTests, cppbuild and gocode make pass.