eslint v6 support

Just like #1834 and #1447, I'm filing this in advance.

eslint v6 alpha has been released.

The current plan is to release a new semver-major of both configs, that supports 3 || 4 || 5 || 6, and the next major after that will drop support for 3 || 4, and only support 5 || 6.

The timeframe for eslint v6 support is "probably not as soon as you would like, but as soon as we can".
Please accept this, and please add no noise to this thread beyond emoji reactions - distractions won't help anyone get the work done any faster.

Please do not file additional issues and do not file pull requests attempting to add support - please, instead, continue to use eslint v5 until such time as our configs support v6.

Peer Dep eslint combined v5 and v6 support released:

eslint v6 is now released.

If you’d like to see our config support it, please submit PRs to the peer dependencies and tools listed above.

WIP PR for eslint-plugin-import(waiting for third party release) - import-js/eslint-plugin-import#1393

eslint-plugin-jsx-a11y is now updated to support ESLint 6 - just for info :)

Downgrade eslint to 5.3.0 until 6.0 is supported: airbnb/javascript#2036

The current peerDependency ^4.19.1 || ^5.3.0 of eslint fails every CI jobs of which the project uses eslint 6

@kaelzhang

@kaelzhang yes, that’s because it’s not yet compatible with eslint v6. Until it is, stick with v5.

@kaelzhang

@kaelzhang yes, that’s because it’s not yet compatible with eslint v6. Until it is, stick with v5.

@ljharb are there specific parts that aren't compatible? Best I can tell, most of the breaking changes were in changing the recommended rules, changing some defaults, or making config parsing stricter.

I'm testing the following setup, and other than the peerDependency warning, everything seems to work (I wouldn't be surprised if something isn't working and I haven't noticed yet, though no lint rules are failing).

{
    "babel-eslint": "^10.0.2",
    "eslint": "^6.0.1",
    "eslint-config-airbnb": "^17.1.1",
    "eslint-plugin-import": "^2.18.0",
    "eslint-plugin-jsx-a11y": "^6.2.3",
    "eslint-plugin-mocha": "^5.3.0",
    "eslint-plugin-react": "^7.14.2",
    "eslint-plugin-react-hooks": "^1.6.1",
    "eslint-plugin-security": "^1.4.0",
}

@MatthewHerbst

@MatthewHerbst until npm ls exits successfully, your dependency graph is invalid - in other words, the peerDependency warning should be gating your CI and preventing the upgrade.

Curious about the status of this. Is this blocked on anything? Are the things people could help out with to move this along?

Yes, it is blocked by sarbbottam/eslint-find-rules#304. Anyone can help it along by submitting a PR that adds eslint 6 support to that package without a breaking change.

[eslint config] [*] [breaking] add eslint v6, drop eslint v4

https://twitter.com/ljharb/status/1160221334502121472?s=21

Both configs have now been released.

[eslint config] [*] [breaking] add eslint v6, drop eslint v4

Navigation Menu

Repository navigation

eslint v6 support #2036

Please do not file additional issues and do not file pull requests attempting to add support - please, instead, continue to use eslint v5 until such time as our configs support v6.

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

eslint v6 support #2036

Description

Please do not file additional issues and do not file pull requests attempting to add support - please, instead, continue to use eslint v5 until such time as our configs support v6.

Activity

ljharb commented on Jun 22, 2019

sheepsteak commented on Jun 23, 2019

sheepsteak commented on Jun 24, 2019

kristho91 commented on Jul 1, 2019

kaelzhang commented on Jul 14, 2019

ljharb commented on Jul 14, 2019

MatthewHerbst commented on Jul 16, 2019

ljharb commented on Jul 16, 2019

bjankord commented on Jul 26, 2019

ljharb commented on Jul 27, 2019

ljharb commented on Aug 10, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions