Skip to content

Imports rules: add eslint flat config support - #2818

Closed
OlivierZal wants to merge 8 commits into
airbnb:masterfrom
OlivierZal:olivierzal/imports_rules/eslint_flat_config_support
Closed

OlivierZal wants to merge 8 commits into
airbnb:masterfrom
OlivierZal:olivierzal/imports_rules/eslint_flat_config_support

Conversation

@OlivierZal

Copy link
Copy Markdown

No description provided.

@ljharb

ljharb commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

This change is fine, but it doesn't actually add flat config support, it just adds a default for a flat config config file.

@ljharb

ljharb commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

Is the only way to support that a new entrypoint? if so, then a /flat entrypoint in both configs seems fine with me.

@OlivierZal
OlivierZal requested a review from ljharb August 31, 2023 22:08
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@ljharb

ljharb commented Aug 31, 2023

Copy link
Copy Markdown
Collaborator

This looks good - obv it's blocked on the import plugin supporting flat config.

@ljharb
ljharb marked this pull request as draft August 31, 2023 22:40
@OlivierZal OlivierZal closed this Sep 2, 2023
@OlivierZal
OlivierZal deleted the olivierzal/imports_rules/eslint_flat_config_support branch September 2, 2023 11:55
@ljharb

ljharb commented Sep 2, 2023

Copy link
Copy Markdown
Collaborator

Why did you delete your fork, making this PR unrecoverable??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants