Repository navigation
test: fail tests when no exception is thrown - #7948
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
Issue1854, Issue1543_1544, CustomErrorMessageTest and CSVTest4 checked the exception only in a catch block with no fail() after the call, so they passed even if the call stopped throwing.
wenshao
approved these changes
Nov 14, 2026
wenshao
left a comment
Member
There was a problem hiding this comment.
No issues found. LGTM! ✅
中文说明
未发现问题。LGTM!✅
— DeepSeek-V4.1-Flash-1017@fda99a87 via Qwen Code /review (v0.27.3)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Issue1854,Issue1543_1544,CustomErrorMessageTestandCSVTest4checked the exception only in a catch block with nofail()after the call, so they passed even if the call stopped throwing. They now useassertThrows, andIssue1854still calls the sameassertValidateoverloads.中文
Issue1854、Issue1543_1544、CustomErrorMessageTest和CSVTest4只在 catch 块里检查异常,调用之后没有fail(),所以即使调用不再抛出异常,测试也会通过。现在改用assertThrows,Issue1854仍然调用相同的assertValidate重载。Summary of your change
Test-only: 33 catch-only checks in four test classes now use
assertThrows.Please indicate you've done the following: