Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Avoid StringIndexOutOfBounds, ensure DateTimeParseException with proper message
Since we are already in the error handling path, the issue being fixed does not break parsing of any valid input. Still, the out-of-bounds access is confusing at first.
Change Summary
Fix the out-of-bounds length arguments to String constructors in the parseLocalDateTime12 method family of DateUtils
The mistake was as simple as it was understandable: the argument passed should be the length to be included in the new String, not the end position inside the byte[] / char[] input. Surrounding calls to the digit* method family of IOUtils take an offset as their second argument, making the addition seem valid at a glance.
Not adding the offset to the constant length fixes the issue.
Validation