Skip to content

update with main - #152

Merged
bart1 merged 131 commits into
106-implement-regular-checksfrom
main
Dec 2, 2025
Merged

bart1 merged 131 commits into
106-implement-regular-checksfrom
main

Conversation

@bart1

@bart1 bart1 commented Dec 2, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

Bart and others added 30 commits July 18, 2025 22:12
Co-authored-by: bart1 <1662852+bart1@users.noreply.github.com>
Co-authored-by: bart1 <1662852+bart1@users.noreply.github.com>
…ull-interval-in-getrad-020

Fix bug in `get_vpts()` date rounding
fix file extention
Skip test if radar has not recently been updated
…n-and-could-be-added

104 romanian radar data is open and could be added
Bart and others added 27 commits October 9, 2025 17:31
…-pvol-data-misses-correct-attributes-for-long-lat-height

fix #139
use httpbingo instead of httpbin for more reliable tests
@bart1 this test is failing (returns NULL rather than the radar name). Rather than fixing it, I don't see the need for this test. We don't use the catch_cnd() approach anywhere else
Fix typo + make error messages consistent
@bart1
bart1 marked this pull request as ready for review December 2, 2025 13:43
@bart1
bart1 merged commit f5f48eb into 106-implement-regular-checks Dec 2, 2025
9 of 10 checks passed
@codecov

codecov Bot commented Dec 2, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.26941% with 94 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (106-implement-regular-checks@d0225f7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
R/get_pvol_us.R 72.05% 19 Missing ⚠️
R/zzz.R 0.00% 19 Missing ⚠️
R/get_pvol_dk.R 0.00% 17 Missing ⚠️
R/utils.R 81.81% 12 Missing ⚠️
R/get_pvol.R 80.76% 5 Missing ⚠️
R/get_vpts_coverage_rmi.R 82.14% 5 Missing ⚠️
R/utils_pvol.R 90.19% 5 Missing ⚠️
R/get_pvol_de.R 97.27% 4 Missing ⚠️
R/get_pvol_nl.R 93.33% 4 Missing ⚠️
R/get_pvol_ee.R 97.36% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@                       Coverage Diff                       @@
##             106-implement-regular-checks     #152   +/-   ##
===============================================================
  Coverage                                ?   92.44%           
===============================================================
  Files                                   ?       24           
  Lines                                   ?     1787           
  Branches                                ?        0           
===============================================================
  Hits                                    ?     1652           
  Misses                                  ?      135           
  Partials                                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants