Skip to content

Simplify homogeneous VariantArray doctest fixtures - #11320

Merged
Jefffrey merged 1 commit into
apache:mainfrom
jabrailkhalil:test/simplify-variant-doctest-fixtures
Oct 2, 2026
Merged

Jefffrey merged 1 commit into
apache:mainfrom
jabrailkhalil:test/simplify-variant-doctest-fixtures

Conversation

@jabrailkhalil

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Follow-up to #11053 and the maintainer discussion there. Related to #8628.

Rationale for this change

The FromIterator<Option<T>> API merged in #11053 accepts homogeneous inputs directly. Five VariantArray doctest examples still construct a one-element string array with a mutable builder and explicit Variant::from conversion.

What changes are included in this PR?

Use VariantArray::from_iter([Some("such wow")]) in these five examples and remove imports made unnecessary by the simpler fixture. The example assertions and resulting values are preserved.

Are these changes tested?

  • cargo +stable fmt --all -- --check: passed.
  • cargo +stable test -p parquet-variant-compute: 369 unit tests and 15 doctests passed.
  • Linux x86_64, Rust 1.98.1 stable.

Are there any user-facing changes?

The documentation examples are simpler. There are no runtime or API changes.

Signed-off-by: jabrailkhalil <jabrailkhalil@gmail.com>
@github-actions github-actions Bot added the parquet-variant parquet-variant* crates label Oct 1, 2026
@Jefffrey Jefffrey added the development-process Internal changes; PRs with this label are excluded from changelog label Oct 2, 2026
@Jefffrey
Jefffrey merged commit 73595d5 into apache:main Oct 2, 2026
17 checks passed
@Jefffrey

Jefffrey commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

thanks @jabrailkhalil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Internal changes; PRs with this label are excluded from changelog parquet-variant parquet-variant* crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants