Repository navigation
Simplify homogeneous VariantArray doctest fixtures - #11320
Merged
Jefffrey merged 1 commit intoOct 2, 2026
Merged
Conversation
Signed-off-by: jabrailkhalil <jabrailkhalil@gmail.com>
Jefffrey
approved these changes
Oct 2, 2026
Contributor
|
thanks @jabrailkhalil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up to #11053 and the maintainer discussion there. Related to #8628.
Rationale for this change
The
FromIterator<Option<T>>API merged in #11053 accepts homogeneous inputs directly. FiveVariantArraydoctest examples still construct a one-element string array with a mutable builder and explicitVariant::fromconversion.What changes are included in this PR?
Use
VariantArray::from_iter([Some("such wow")])in these five examples and remove imports made unnecessary by the simpler fixture. The example assertions and resulting values are preserved.Are these changes tested?
cargo +stable fmt --all -- --check: passed.cargo +stable test -p parquet-variant-compute: 369 unit tests and 15 doctests passed.Are there any user-facing changes?
The documentation examples are simpler. There are no runtime or API changes.