small refactors on account manager by DaanHoogland · Pull Request #11784 · apache/cloudstack

DaanHoogland · 2025-10-03T10:34:09Z

Description

This PR does some small refactors encountered during trouble shooting. ...

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-10-03T10:42:46Z

Codecov Report

❌ Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.76%. Comparing base (d6390bd) to head (c20d96a).

Files with missing lines	Patch %	Lines
...c/main/java/com/cloud/user/AccountManagerImpl.java	58.33%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11784   +/-   ##
=========================================
  Coverage     20.76%   20.76%           
- Complexity    21903    21910    +7     
=========================================
  Files          6496     6496           
  Lines        591612   591612           
  Branches      72585    72584    -1     
=========================================
+ Hits         122851   122868   +17     
+ Misses       455424   455407   -17     
  Partials      13337    13337

Flag	Coverage Δ
uitests	`3.88% <ø> (ø)`
unittests	`22.07% <58.33%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull Request Overview

This PR performs small refactoring improvements to the AccountManagerImpl class to enhance code readability and maintainability. The changes include simplifying conditional logic, extracting reusable methods, and updating logging patterns.

Simplified multiple conditional statements to use direct return expressions
Extracted domain ID calculation logic into a reusable private method
Updated logging to use parameterized format and modern charset handling

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

hsato03

clgtm

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

blueorangutan · 2026-08-18T06:04:19Z

[SF] Trillian test result (tid-16768)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56898 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11784-t16768-kvm-ol8.zip
Smoke tests completed. 155 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_ssl_offloading_isolated_network	`Failure`	710.49	test_ssl_offloading.py
test_02_ssl_offloading_project_vpc	`Failure`	809.94	test_ssl_offloading.py

RosiKyu · 2026-09-08T05:10:51Z

@DaanHoogland could you merge main into this branch please?

The PR targets main (24.0) but the branch is still on 4.23.0.0-SNAPSHOT, so the PR packages are being built as 4.23 and we cannot test them against a 24.0 environment.

Copilot

🟡 Changes recommended

The domain-grouping map lookup in checkAccess still uses entity.getDomainId() instead of the resolved domainId, which can drop earlier entities and break the new test expectations.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Files reviewed: 2/2 changed files
Comments generated: 1
Review effort level: Lite

-                Account account = ApiDBUtils.findAccountById(entity.getAccountId());
-                domainId = account != null ? account.getDomainId() : -1;
-            }
+            long domainId = getDomainIdFor(entity);


nvazquez · 2026-10-28T02:22:13Z

@blueorangutan package

blueorangutan · 2026-10-28T02:24:09Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-10-28T03:48:31Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 19784

DaanHoogland · 2026-10-28T11:31:09Z

I will revisit these kinds of refactors in quieter times

DaanHoogland · 2026-11-02T10:58:21Z

@blueorangutan package

blueorangutan · 2026-11-02T11:00:06Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Copilot

🟢 Approval recommended

No active review issues remain, and regression coverage addresses the corrected domain-resolution and grouping behavior.

1 open issue

The domainId is now resolved via getDomainIdFor(entity), but the domains map still looks up…

_{Review effort: Lite}

blueorangutan · 2026-11-02T12:50:33Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19877

DaanHoogland · 2026-11-03T11:13:19Z

@blueorangutan test

blueorangutan · 2026-11-03T11:14:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-11-04T03:45:02Z

[SF] Trillian test result (tid-17475)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56041 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11784-t17475-kvm-ol8.zip
Smoke tests completed. 157 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland modified the milestones: 4.23, 4.20.3 Oct 3, 2025

DaanHoogland requested a lite review from Copilot October 6, 2025 06:07

Copilot AI reviewed Oct 6, 2025

View reviewed changes

Comment thread server/src/main/java/com/cloud/user/AccountManagerImpl.java Resolved

DaanHoogland marked this pull request as ready for review October 7, 2025 07:09

DaanHoogland added the status:needs-testing label Oct 20, 2025

DaanHoogland force-pushed the accountManagerRefactors branch from 9dc2f0d to bee7667 Compare December 8, 2025 15:34

apache deleted a comment from blueorangutan Dec 8, 2025

DaanHoogland force-pushed the accountManagerRefactors branch from bee7667 to 9c9bb32 Compare December 8, 2025 15:50

apache deleted a comment from blueorangutan Dec 9, 2025

hsato03 reviewed Dec 9, 2025

View reviewed changes

Comment thread server/src/main/java/com/cloud/user/AccountManagerImpl.java Resolved

hsato03 approved these changes Dec 9, 2025

View reviewed changes

DaanHoogland marked this pull request as draft December 11, 2025 07:22

DaanHoogland force-pushed the accountManagerRefactors branch from 9c9bb32 to 10fa999 Compare December 12, 2025 07:25

DaanHoogland requested review from Copilot and sureshanaparti December 12, 2025 07:25

Copilot started reviewing on behalf of DaanHoogland December 12, 2025 07:26

View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

Comment thread server/src/main/java/com/cloud/user/AccountManagerImpl.java Resolved

DaanHoogland force-pushed the accountManagerRefactors branch from 10fa999 to a9df597 Compare December 23, 2025 19:41

apache deleted a comment from blueorangutan Aug 17, 2026

DaanHoogland marked this pull request as ready for review August 18, 2026 07:26

DaanHoogland moved this from Backlog to Ready in CloudStack Testing Aug 31, 2026

DaanHoogland unassigned vishesh92 Sep 1, 2026

RosiKyu self-assigned this Sep 8, 2026

Copilot AI review requested due to automatic review settings September 8, 2026 07:00

DaanHoogland force-pushed the accountManagerRefactors branch from ef1e1d8 to 55eae45 Compare September 8, 2026 07:00

Copilot started reviewing on behalf of DaanHoogland September 8, 2026 07:00

View session

Copilot AI reviewed Sep 8, 2026

View reviewed changes

Comment thread server/src/main/java/com/cloud/user/AccountManagerImpl.java

Account account = ApiDBUtils.findAccountById(entity.getAccountId());

domainId = account != null ? account.getDomainId() : -1;

}

long domainId = getDomainIdFor(entity);

DaanHoogland marked this pull request as draft October 28, 2026 11:31

DaanHoogland added 3 commits November 2, 2026 11:48

small refactors on account manager

9e4ca84

fix duplicate import + tests

0ec0339

account manager: group entities by resolved domain id in checkAccess

c20d96a

DaanHoogland force-pushed the accountManagerRefactors branch from 55eae45 to c20d96a Compare November 2, 2026 10:54

DaanHoogland marked this pull request as ready for review November 2, 2026 10:57

Copilot AI lite review requested due to automatic review settings November 2, 2026 10:57

Copilot started reviewing on behalf of DaanHoogland November 2, 2026 10:58

View session

Copilot AI reviewed Nov 2, 2026

View reviewed changes

Conversation

DaanHoogland commented Oct 3, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov Bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

hsato03 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

blueorangutan commented Aug 18, 2026

Uh oh!

RosiKyu commented Sep 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

nvazquez commented Oct 28, 2026

Uh oh!

blueorangutan commented Oct 28, 2026

Uh oh!

blueorangutan commented Oct 28, 2026

Uh oh!

DaanHoogland commented Oct 28, 2026

Uh oh!

DaanHoogland commented Nov 2, 2026

Uh oh!

blueorangutan commented Nov 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

blueorangutan commented Nov 2, 2026

Uh oh!

DaanHoogland commented Nov 3, 2026

Uh oh!

blueorangutan commented Nov 3, 2026

Uh oh!

blueorangutan commented Nov 4, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov Bot commented Oct 3, 2025 •

edited

Loading