Skip to content

Use 2 partitions in planner tests - #17

Merged
andygrove merged 3 commits into
apache:mainfrom
andygrove:use-2-partitions
Oct 4, 2024
Merged

andygrove merged 3 commits into
apache:mainfrom
andygrove:use-2-partitions

Conversation

@andygrove

Copy link
Copy Markdown
Member

Use 2 partitions so that we have distributed plans with multiple query stages

@andygrove andygrove changed the title Use 2 partitions Use 2 partitions in planner tests Oct 4, 2024
Comment thread src/planner.rs
let sql = fs::read_to_string(&file)?;
let config = SessionConfig::new().with_target_partitions(1);
let ctx = SessionContext::with_config(config);
let config = SessionConfig::new().with_target_partitions(2);

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main change

Comment thread README.md
cargo test
```

Tests compare plans with expected plans, which unfortunately contain the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is not needed anymore, can we also remove the script ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was removed in my previous PR, but I missed this documentation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, my previous review was not deep enough

@andygrove
andygrove merged commit b91705c into apache:main Oct 4, 2024
@andygrove
andygrove deleted the use-2-partitions branch October 4, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants