Repository navigation
Conversation
Use the log clock for online validation, periodic expiration, and writer state reload. Add deterministic regressions for sequence ordering, expiration, and snapshot recovery with ManualClock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAI Codex assisted with the implementation, tests, and PR preparation.
Purpose
Linked issue: close #4878
Writer expiration compared batch timestamps from the injected
Clockwith system time. Under aManualClock, a fresh batch could be treated as expired, allowing sequence 1 to be accepted before a delayed sequence 0 and causing the earlier batch to be treated as committed on retry.Brief change log
LogTablet.LogLoaderfor writer-state snapshot/replay rebuild. Retain system time for elapsed-duration logging.Tests
ManualClockregressions cover first-sequence validation, periodic expiration, and snapshot reload. They use an explicit 10-second expiration interval; the append test also verifies that persisted batch timestamps are zero.LogTabletTesttests pass.LogTabletTest,LogLoaderTest, andWriterStateManagerTest, and all four cases ofFlinkTableSourceITCase#testLookupCustomShuffle(inherited byFlink22TableSourceITCase, executed influss-flink-2.2) passed on Java 11. Production code is unchanged since those runs.fluss-serverlog package and its tests; client and Flink production code is unchanged.API and Format
No public API, protocol, or storage-format change.
Documentation
No documentation change.