[caicancai]

Learn from opendal's documentation and add contribution documentation to iggy

[kparisa]

@caicancai thanks for the PR. We should also add this to Iggy's website [iggy.apache.org]
Do you want to contribute there as well? https://github.com/apache/iggy-website

[caicancai]

@caicancai thanks for the PR. We should also add this to Iggy's website [iggy.apache.org] Do you want to contribute there as well? https://github.com/apache/iggy-website

@hubcio @kparisa Thank you for your reply. If this PR is merged, I will update this document to the official website.

[spetz]

Hey,
Thanks for the contribution, we need to verify why does the CI check fails, as it looks like some issue with resolving the origin.

[martin-g]

Wild guess: most probably because the contributor forked just the master branch (this is the default Github behavior).

[caicancai]

Hey, Thanks for the contribution, we need to verify why does the CI check fails, as it looks like some issue with resolving the origin.

Do you mind if I try to fix it?

[spetz]

Hey, Thanks for the contribution, we need to verify why does the CI check fails, as it looks like some issue with resolving the origin.

Do you mind if I try to fix it?

Feel free to do it :)

[caicancai]

Wild guess: most probably because the contributor forked just the master branch (this is the default Github behavior).

@spetz @martin-g Your guess is correct, because the other PR #1712 did not fork the master branch, and its CI did not fail.

test https://github.com/caicancai/iggy/pull/1/checks

[martin-g]

Your guess is correct

Thanks for confirming!
I have faced this issue in the past too!

https://github.com/apache/iggy/blob/master/.github/scripts/detect-changed-files.sh could be dropped in favor of action like https://github.com/Ana06/get-changed-files

[spetz]

I think it should work now thanks to #1738