Repository navigation
feat(connectors): add connectors runtime - #1826
Merged
Merged
Conversation
spetz
force-pushed
the
connectors
branch
2 times, most recently
from
May 28, 2025 08:47
b5f77c1 to
39d9249
Compare
spetz
force-pushed
the
connectors
branch
8 times, most recently
from
May 28, 2025 17:47
6e46f18 to
50ddf32
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds the Rust SDK and runtime for dynamically loaded source and sink connectors, supporting custom plugins via C FFI and per-field data transformations.
- Introduces text, raw, and JSON decoders in the SDK
- Implements runtime logic to load, initialize, and manage source and sink plugins with transform support
- Provides example data producer, Docker setup, and documentation
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| core/connectors/sdk/src/decoders/text.rs | New text stream decoder implementation |
| core/connectors/sdk/src/decoders/raw.rs | New raw stream decoder implementation |
| core/connectors/sdk/src/decoders/json.rs | New JSON stream decoder using simd_json |
| core/connectors/sdk/src/decoders/mod.rs | Expose decoder modules |
| core/connectors/sdk/Cargo.toml | SDK crate manifest |
| core/connectors/runtime/src/transform.rs | Load and filter transforms from config |
| core/connectors/runtime/src/source.rs | Runtime logic for loading and handling source plugins |
| core/connectors/runtime/src/sink.rs | Runtime logic for loading and handling sink plugins |
| core/connectors/runtime/src/main.rs | Runtime entrypoint and plugin orchestration |
| core/connectors/runtime/src/configs.rs | Runtime configuration definitions |
| core/connectors/runtime/src/error.rs | Runtime error enum |
| core/connectors/runtime/config.toml | Sample runtime configuration |
| core/connectors/runtime/Cargo.toml | Runtime crate manifest |
| core/connectors/docker-compose.yml | Docker compose for example services |
| core/connectors/data_producer/src/main.rs | Example data producer application |
| core/connectors/data_producer/Cargo.toml | Data producer crate manifest |
| core/connectors/README.md | Connectors documentation and quick start guide |
| README.md | Monorepo updates adding connectors section |
| DEPENDENCIES.md | Added new connector dependencies |
| Cargo.toml | Workspace members and dependency updates |
Comments suppressed due to low confidence (3)
core/connectors/runtime/src/transform.rs:31
- [nitpick] Using
unwrap_or_default()on deserialization will silently ignore parsing errors. Consider handling errors explicitly and logging them before defaulting to avoid hidden misconfigurations.
let shared_config = serde_json::from_value::<SharedTransformConfig>(transform_config.clone()).unwrap_or_default();
core/connectors/runtime/src/source.rs:271
- [nitpick] Using
eprintln!bypasses the structured logging system. Replace with atracing::error!call to keep logs consistent with the rest of the runtime.
eprintln!("Failed to deserialize produced messages for source connector with ID: {plugin_id}");
core/connectors/runtime/config.toml:73
- There's a typo in the table name
ransforms; it should betransformsto match the rest of the configuration structure.
[[sinks.quickwit.ransforms.add_fields.fields]]
spetz
force-pushed
the
connectors
branch
5 times, most recently
from
May 29, 2025 19:42
75f90df to
30134c0
Compare
numinnex
approved these changes
May 31, 2025
numinnex
previously approved these changes
May 31, 2025
hubcio
reviewed
May 31, 2025
spetz
force-pushed
the
connectors
branch
2 times, most recently
from
May 31, 2025 17:19
e94f709 to
432ff1a
Compare
numinnex
approved these changes
May 31, 2025
hubcio
approved these changes
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the connector runtime, allowing to build the custom plugins in Rust (
sinksandsources), which will be loaded during the runtime start, and invoked when either consuming the batch of messages (sink), or producing them (source) via exposed C FFI to ensure the maximum efficiency and performance. Moreover, it's possible to make use of the data transformations (per-field, depending on the supported payload format).This is the very first version of the runtime, yet the overall framework along with the exposed traits, should allow for the smooth implementation of the custom plugins and data transformations.