Repository navigation
chore(example): move getting-started for python sdk - #2094
Merged
Merged
Conversation
Contributor
|
Thank you for the contribution! I think that the requirements file needs the ASF license header included too. |
changhc
marked this pull request as ready for review
August 10, 2025 14:55
spetz
approved these changes
Aug 10, 2025
hubcio
approved these changes
Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The first part of #1889.
I'm not sure if the person assigned to the issue is already working on this. It's been several weeks since the last update, so I assume that this is not being worked on at the moment. If it turns out that the person almost has a PR ready, I'll close mine.
This PR basically duplicates the existing Python SDK example and places it in
examples/python/getting-started. Main changes:examples/rust/getting-started.examples/rust/getting-started. Note that the logged messages are not exactly the same as those lines inexamples/rust/getting-started, but I consider this rather minor now and therefore leave them as they are.Note that this PR works with
5627b18rather than the latest release (0.4.0). I decided not to build against 0.4.0 because the examples will not be aligned with the current rust examples.There are a few issues in my opinion regarding the setup and target version of iggy in the example:
Testing
Automated testing will be set up later.