Repository navigation
feat(proc): Implement Processor Infrastructure/Libraries (for flink to start with) - #2275
Merged
Merged
Conversation
…library/src/test/java/org/apache/iggy/connector/config/OffsetConfigTest.java
Contributor
Author
Contributor
Author
|
@mmodzelewski please review |
mmodzelewski
requested changes
Oct 20, 2025
mmodzelewski
left a comment
mmodzelewski
left a comment
Member
There was a problem hiding this comment.
Hi @chiradip, the PR looks good, thanks. I left one small comment, please fix it, and we can merge the PR.
I'm also wondering if all the configuration classes need to be Serializable. Do you see a use case where these configurations will be sent over wire rather than configure the client at hand?
…library/README.md
mmodzelewski
approved these changes
Oct 22, 2025
numinnex
approved these changes
Oct 22, 2025
hageshiame
pushed a commit
to hageshiame/iggy
that referenced
this pull request
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.