Skip to content

feat(sdk): support hostnames in QUIC and WebSocket clients - #2768

Merged
hubcio merged 7 commits into
apache:masterfrom
seokjin0414:2729-support-hostnames
Feb 19, 2026
Merged

hubcio merged 7 commits into
apache:masterfrom
seokjin0414:2729-support-hostnames

Conversation

@seokjin0414

@seokjin0414 seokjin0414 commented Feb 18, 2026 •

Copy link
Copy Markdown
Contributor

Closes #2729

Summary

  • Support hostnames in QUIC and WebSocket clients via tokio::net::lookup_host()
  • QUIC create(): defer SocketAddr parsing, store raw address string
  • QUIC/WebSocket connect(): replace parse::<SocketAddr>() with lookup_host()
  • Remove localhost → 127.0.0.1 workaround in CLI args

Tests

  • QUIC: create() with hostname and FQDN succeeds
  • QUIC: raw hostname stored in current_server_address
  • QUIC/WebSocket: from_connection_string with hostname succeeds

@codecov

codecov Bot commented Feb 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.60274% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.32%. Comparing base (4107de2) to head (66d67d1).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
core/sdk/src/quic/quic_client.rs 80.39% 6 Missing and 4 partials ⚠️
core/sdk/src/websocket/websocket_client.rs 55.55% 6 Missing and 2 partials ⚠️
core/common/src/types/args/mod.rs 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2768      +/-   ##
============================================
+ Coverage     68.27%   68.32%   +0.05%     
  Complexity      656      656              
============================================
  Files           741      741              
  Lines         62165    62210      +45     
  Branches      58578    58623      +45     
============================================
+ Hits          42445    42507      +62     
+ Misses        17612    17590      -22     
- Partials       2108     2113       +5     
Flag Coverage Δ
java 52.19% <ø> (ø)
rust 69.39% <72.60%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
core/common/src/types/args/mod.rs 46.05% <50.00%> (+2.30%) ⬆️
core/sdk/src/websocket/websocket_client.rs 61.00% <55.55%> (+0.36%) ⬆️
core/sdk/src/quic/quic_client.rs 71.20% <80.39%> (+1.91%) ⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread core/sdk/src/quic/quic_client.rs
…rsing

Make SocketAddr parsing optional in QuicClient::create() so hostnames
like "localhost:8080" don't fail. Store raw server address string
(matching TCP client pattern) and defer DNS resolution to connect().

Signed-off-by: shin <sars21@hanmail.net>
Replace parse::<SocketAddr>() with tokio::net::lookup_host() in
QuicClient::connect() to support hostnames. quinn::Endpoint::connect()
requires SocketAddr, so DNS resolution is performed here.

Signed-off-by: shin <sars21@hanmail.net>
Replace parse::<SocketAddr>() with tokio::net::lookup_host() in
WebSocketClient::connect() to support hostnames. Downstream code
requires SocketAddr (connect_tls, connect_plain, client_address,
WebSocketConnectionStream), so DNS resolution is needed here.

Signed-off-by: shin <sars21@hanmail.net>
Remove .replace("localhost", "127.0.0.1") calls from
Args::get_server_address(). SDK now resolves hostnames natively
in QUIC and WebSocket clients, making this workaround unnecessary.

Signed-off-by: shin <sars21@hanmail.net>
Signed-off-by: seokjin0414 <sars21@hanmail.net>
Signed-off-by: shin <sars21@hanmail.net>
…etAddrs

Signed-off-by: seokjin0414 <sars21@hanmail.net>
Signed-off-by: shin <sars21@hanmail.net>
@seokjin0414
seokjin0414 force-pushed the 2729-support-hostnames branch from 8227de0 to 66d67d1 Compare February 19, 2026 12:13
@hubcio
hubcio merged commit e03355b into apache:master Feb 19, 2026
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support hostnames in iggy-bench

3 participants