Skip to content

ci: add Codecov coverage for Node SDK (#2774) - #2792

Merged
mmodzelewski merged 3 commits into
apache:masterfrom
atharvalade:add-node-codecov-coverage
Feb 26, 2026
Merged

mmodzelewski merged 3 commits into
apache:masterfrom
atharvalade:add-node-codecov-coverage

Conversation

@atharvalade

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #2774

Rationale

Rust and Java already upload coverage to Codecov — Node SDK was missing.

What changed?

Replaced npm run test:unit / npm run test:e2e in the pre-merge action with direct node invocations that add --test-reporter=lcov --test-reporter-destination=../../reports/node-coverage/lcov.info, using Node 23's native lcov support (no new dependencies). Added Codecov upload steps in _test.yml (pre-merge) and a node-coverage baseline job in post-merge.yml, following the same pattern as Java. Registered the node flag in codecov.yml and removed foreign/node/** from the ignore list.

Local Execution

  • CI-only workflow changes, no local server setup
  • Pre-commit hooks ran

AI Usage

  1. Opus 4.6
  2. Used to scaffold the workflow YAML following existing Java/Rust patterns
  3. Verified by diffing against existing Java coverage steps and reviewing all four files
  4. Yes

@atharvalade
atharvalade force-pushed the add-node-codecov-coverage branch from 7a48ff7 to c699430 Compare February 20, 2026 21:12
@codecov

codecov Bot commented Feb 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.45%. Comparing base (57da007) to head (47ed8b9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2792      +/-   ##
============================================
+ Coverage     68.53%   71.45%   +2.92%     
  Complexity      708      708              
============================================
  Files           859      968     +109     
  Lines         68409    78156    +9747     
  Branches      59685    59975     +290     
============================================
+ Hits          46884    55848    +8964     
- Misses        19193    19961     +768     
- Partials       2332     2347      +15     
Flag Coverage Δ
csharp 67.06% <ø> (-0.19%) ⬇️
java 54.02% <ø> (ø)
node 92.18% <ø> (?)
rust 69.60% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 125 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hubcio

hubcio commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

The CODECOV_TOKEN secret is not passed to test-node in pre-merge.yml, so the upload will silently fail. Need to add secrets: CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} to the test-node job.

@atharvalade
atharvalade force-pushed the add-node-codecov-coverage branch from c699430 to 7f6ef8e Compare February 24, 2026 08:45
@atharvalade

Copy link
Copy Markdown
Contributor Author

The CODECOV_TOKEN secret is not passed to test-node in pre-merge.yml, so the upload will silently fail. Need to add secrets: CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} to the test-node job.

done

Comment thread .github/workflows/post-merge.yml Outdated
@atharvalade
atharvalade force-pushed the add-node-codecov-coverage branch from 82f33c6 to 5d7b849 Compare February 24, 2026 21:43
@mmodzelewski
mmodzelewski merged commit f585773 into apache:master Feb 26, 2026
71 checks passed
kriti-sc pushed a commit to kriti-sc/iggy that referenced this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Codecov coverage for Node SDK

3 participants