Repository navigation
Conversation
dajneem23
marked this pull request as draft
February 24, 2026 08:16
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2804 +/- ##
============================================
+ Coverage 68.33% 68.34% +0.01%
Complexity 739 739
============================================
Files 1052 1053 +1
Lines 84745 84763 +18
Branches 61281 61308 +27
============================================
+ Hits 57910 57933 +23
+ Misses 24463 24452 -11
- Partials 2372 2378 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dajneem23
force-pushed
the
feature/2722-delete-segments-command-for-http
branch
from
February 24, 2026 08:33
caec235 to
94b141b
Compare
dajneem23
marked this pull request as ready for review
February 24, 2026 08:41
dajneem23
marked this pull request as draft
February 24, 2026 08:53
dajneem23
force-pushed
the
feature/2722-delete-segments-command-for-http
branch
from
February 24, 2026 08:55
94b141b to
4625029
Compare
dajneem23
marked this pull request as ready for review
February 24, 2026 09:08
spetz
requested changes
Mar 5, 2026
spetz
left a comment
Contributor
There was a problem hiding this comment.
Looks good, please update server.http file with example request in core/server and that should be it.
dajneem23
force-pushed
the
feature/2722-delete-segments-command-for-http
branch
from
March 6, 2026 01:57
130fcb9 to
8497ad6
Compare
spetz
approved these changes
Mar 6, 2026
hubcio
approved these changes
Mar 6, 2026
kriti-sc
pushed a commit
to kriti-sc/iggy
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2722
Rationale
delete_segmentsalready exists in binary/CLI/MCP and the HTTP SDK client already sends it, but the server HTTP API had no matching handler, so requests returned404. This left HTTP behavior inconsistent with other transports.What changed?
cargo fmt --all,cargo check -p server,cargo test -p integration --test mod --no-runcargo test --package integration --test mod -- server::general::authentication --nocapturedelete_segmentsincore/server/src/http/segments.rs, following the same flow as partitions: parse path/query, validate, run permission check, -calldelete_segments_base, and applyDeleteSegmentsstate command./streams/{stream_id}/topics/{topic_id}/partitions/{partition_id}withDELETE.core/integration/tests/server/scenarios/system_scenario.rsto calldelete_segmentsat the end and verify partitionsegments_countbefore/after.web/docs/server-api.httpwith:Local Execution
Passed:
cargo fmt --allcargo check -p servercargo test -p integration --test mod --no-runcargo test --package integration --test mod -- server::general::authentication --nocapturePre-commit hooks ran: ran
AI Usage