Repository navigation
feat(shard): Implement shard router - #2853
Merged
Merged
Conversation
krishvishal
force-pushed
the
shard-router
branch
from
March 3, 2026 08:11
c010536 to
3a41f08
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2853 +/- ##
============================================
- Coverage 67.91% 67.77% -0.14%
Complexity 739 739
============================================
Files 1049 1051 +2
Lines 84394 84544 +150
Branches 60973 61132 +159
============================================
- Hits 57313 57300 -13
- Misses 24720 24874 +154
- Partials 2361 2370 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
|
can you use |
Member
Author
Okay, I will look into it. |
krishvishal
commented
Mar 3, 2026
numinnex
requested changes
Mar 3, 2026
numinnex
requested changes
Mar 4, 2026
numinnex
previously approved these changes
Mar 4, 2026
Replace manual `is_applicable` + `inner()` destructuring in on_request, on_replicate, and on_ack with direct MuxPlane trait dispatch, now that apache#2857 unified both planes on Plane<VsrConsensus<B>>.
PlaneIdentity impls
krishvishal
force-pushed
the
shard-router
branch
from
March 4, 2026 12:35
d5ab7cb to
d81c3fd
Compare
Member
Author
|
Fixed merge conflicts. |
numinnex
approved these changes
Mar 4, 2026
hubcio
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the shard router each shard gets an inbox (flume channel) and a vector of senders to all other shards (including itself). When a message arrives at any shard, the router:
The message pump (run_message_pump) drains the inbox and processes frames sequentially, ensuring all mutations on a given shard are serialized through a single async task.
The ShardsTable trait abstracts partition ownership lookup with two implementations: