Repository navigation
HDDS-16462. Recon full snapshot onto an earlier OM lineage plus crash permanently serves stale derived data. - #11933
Draft
ArafatKhan2198 wants to merge 1 commit into
Draft
ArafatKhan2198 wants to merge 1 commit into
ArafatKhan2198 wants to merge 1 commit into
Conversation
… permanently serves stale derived data Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
On startup, Recon rebuilds its derived tables only if a task's sequence number is behind the OM sync sequence number. But the OM sequence number can go backwards, for example after OM is restored from a backup.
Example:
Fix: rebuild when the numbers are different (
!= 0) instead of only when the task is behind (< 0). The normal cases (behind → rebuild, equal → no rebuild) don't change. The check is moved into a small helper,getTasksToReprocessOnStartup, so it can be unit tested.This is rare (OM going back in time and a Recon restart during the rebuild), but when it happens the stale data is silent and never fixes itself.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16462
How was this patch tested?
testStartupReconciliationReprocessesTaskOnLineageRegressioncovers ahead, behind and equal.TestOzoneManagerServiceProviderImplpasses (17/17), and checkstyle is clean.