Repository navigation
fix: handle container clean failing on read-only named volume mounts - #2228
Merged
Merged
Conversation
- Skip trim on read-only rootfs and read-only block mounts - Keep cleaning after a failure, then throw one error listing failed paths - Add integration tests for read-only rootfs, read-only volume, and mixed volumes Fixes apple#2224
zdk
changed the title
zdk
changed the title
Code Coverage
|
6 tasks
daphnediane
added a commit
to daphnediane/container-distro
that referenced
this pull request
Oct 6, 2026
Cross-references the open roadmap items with their new tracking issues, moves the container-internals re-verification into the release checklist (issue #10 closed as a process check), and migrates all markdown to the reference-link convention. - TODO.md: link each open item to its issue (#1-#9, #11-#14); drop "Upstream-internal assumptions" (now a release-process step) - Gap docs + remote-wsl-interop.md: "**Tracking:**" header lines - security.md: pre-1.0 checklist items 5 and 6 link #12/#13 - install.md: note no brew/nix/pkg packages yet (#14) - release.md: re-verify appRoot internals + extend VERIFIED_CONTAINER_MINOR when container's minor version changes - container-internals.md: re-verify checklist points at release.md - ops.rs migrate doc comment links #1; VERIFIED_CONTAINER_MINOR doc notes the release-checklist step - All inline `[text](target)` links converted to `[text]` shortcut references with targets collected in a bibliography at each file's end; bare text kept when the path is the text - External issue refs use `[owner/repo#N]` (e.g. [apple/container#1805]); bare `[#N]` is reserved for this repo's issues - Em-dashes normalized to `--` (MD060 miscounts Unicode width in tables); table pipes re-aligned - Pipes inside code spans in tables escaped (`\|`) so rows parse as two cells (MD056) - Prose reflowed to ~72 columns now that reference labels are short; `**Status:**`/`**Fix level:**`/`**Tracking:**` header lines in gap docs became bullet lists Prompt: [verbatim] Link those issues to TODO and other documentation / code if it make sense to link somewhere else as well Followup: [verbatim] I don't think #10 should be an issue, that is process check, and possibly best to just validate if the version changed as part of the release process. I'm closing that issue Followup: [summarized] Prefer reference-style links with targets in a bibliography at the end of the file; fix all similar links in the markdown files. Followup: [verbatim] External project issues should be linked like [apple/container#2228] not [#2228] with a glossary Followup: [summarized] Em-dashes replaced with `--` throughout; MD060's column-width counting mishandles Unicode in tables. Followup: [summarized] Reflow block text: early line breaks left over from long inline links were re-wrapped to ~72 columns; `**Status:**`-style gap-doc headers became bullet lists. Co-Authored-By: Devin (SWE-2 High) <158243242+devin-ai-integration[bot]@users.noreply.github.com>
daphnediane
added a commit
to daphnediane/container-distro
that referenced
this pull request
Oct 6, 2026
Cross-references the open roadmap items with their new tracking issues, moves the container-internals re-verification into the release checklist (issue #10 closed as a process check), and migrates all markdown to the reference-link convention. - TODO.md: link each open item to its issue (#1-#9, #11-#14); drop "Upstream-internal assumptions" (now a release-process step) - Gap docs + remote-wsl-interop.md: "**Tracking:**" header lines - security.md: pre-1.0 checklist items 5 and 6 link #12/#13 - install.md: note no brew/nix/pkg packages yet (#14) - release.md: re-verify appRoot internals + extend VERIFIED_CONTAINER_MINOR when container's minor version changes - container-internals.md: re-verify checklist points at release.md - ops.rs migrate doc comment links #1; VERIFIED_CONTAINER_MINOR doc notes the release-checklist step - All inline `[text](target)` links converted to `[text]` shortcut references with targets collected in a bibliography at each file's end; bare text kept when the path is the text - External issue refs use `[owner/repo#N]` (e.g. [apple/container#1805]); bare `[#N]` is reserved for this repo's issues - Em-dashes normalized to `--` (MD060 miscounts Unicode width in tables); table pipes re-aligned - Pipes inside code spans in tables escaped (`\|`) so rows parse as two cells (MD056) - Prose reflowed to ~72 columns now that reference labels are short; `**Status:**`/`**Fix level:**`/`**Tracking:**` header lines in gap docs became bullet lists Prompt: [verbatim] Link those issues to TODO and other documentation / code if it make sense to link somewhere else as well Followup: [verbatim] I don't think #10 should be an issue, that is process check, and possibly best to just validate if the version changed as part of the release process. I'm closing that issue Followup: [summarized] Prefer reference-style links with targets in a bibliography at the end of the file; fix all similar links in the markdown files. Followup: [verbatim] External project issues should be linked like [apple/container#2228] not [#2228] with a glossary Followup: [summarized] Em-dashes replaced with `--` throughout; MD060's column-width counting mishandles Unicode in tables. Followup: [summarized] Reflow block text: early line breaks left over from long inline links were re-wrapped to ~72 columns; `**Status:**`-style gap-doc headers became bullet lists. Co-Authored-By: Devin (SWE-2 High) <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
container cleanfails withfilesystemOperation trim failedwhen the container has a named volume mounted read-only, because the runtime helper tries to trim every block mount and throws on the first error.The fix:
--read-only, and skips block mounts whose options includero.Fixes #2224
Testing