Repository navigation
K8s Plugin: sanitize kubeconfig values from guest before merging with host kubeconfig - #2310
Merged
katiewasnothere merged 1 commit intoSep 28, 2026
Conversation
… host kubeconfig Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
realrajaryan
approved these changes
Sep 28, 2026
Code Coverage
|
|
Hi Container team, Thank you for the fix and for publishing the advisory. Best regards, |
6 tasks
devops-thiago
added a commit
to devops-thiago/container
that referenced
this pull request
Oct 9, 2026
…kubeconfig (#53) * K8s Plugin: sanitize kubeconfig values from guest before merging with host kubeconfig (apple#2310) Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com> (cherry picked from commit 31a069a) * fix(build): declare ContainerNetworkClient's dependency on ContainerVersion NetworkClient.swift imports ContainerVersion for ServiceIdentity.machPrefix, but the target did not declare it. The Swift 6.4 build links each test product strictly and ContainerNetworkServerTests failed with an undefined machPrefix symbol. --------- Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com> Co-authored-by: Kathryn Baldauf <k_baldauf@apple.com>
This comment was marked as duplicate.
This comment was marked as duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Prevent container-controlled kubeconfig from enabling arbitrary command execution on the host. This additionally adds a new guard that the kubeconfig in the guest only has a single entry for each of clusters, users, and contexts. Previously if there were multiple of these, the code would rewrite the names for each to be containerID so we'd be quietly corrupting the kubeconfig.
Testing