Repository navigation
Fix container log following when the log is empty - #2377
Merged
Merged
Conversation
github-actions
Bot
added
documentation
Code Coverage
|
3 tasks
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
container logs -fexits when its initial read finds an empty log.Skip the empty initial read without returning, so follow mode can wait for new output.
Keep the full-file read to preserve existing output before following.
Add a regression test for output appended to an initially empty log.
Leave
container machine logsunchanged because it has a separate implementation and this issue concernscontainer logs.Closes #2374.
Testing
Repro command, with an initially empty container log:
Verified at the file-tail level on macOS: before the fix, it returns immediately; after, it waits and prints
hellowhen appended.ContainerLogsTests.followsInitiallyEmptyLogfails before the fix and passes after it.I am new to open source, and this pull request was made with AI assistance.