Repository navigation
Conversation
Read the alternative metadata filename when action.yml is absent, while preserving the existing lookup precedence. This allows actions that use action.yaml to be generated and resolves issue apple#209.
StefMa
approved these changes
Oct 18, 2026
StefMa
left a comment
Contributor
There was a problem hiding this comment.
The PR description is misleading as we are already respecting .yaml files. You only add the tried urls to the failure message. Which is a little improvement 🤷♂️ 🙃
Add offline Pkl regressions for the existing lookup preference and the tag, branch, and nested action.yaml fallbacks. Reuse the repository's test mode convention to read local metadata fixtures. Keep the normal GitHub URLs and lookup order unchanged.
Author
|
Thank you for your review. I'm sorry my earlier description wasn't precise enough. I've clarified the PR description and added regression tests. I appreciate your time and feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try
action.yamlwhen the existingaction.ymllookups find no remote metadata, reusing the existing YAML parser. Preserve the lookup order and identify both filenames in the missing-metadata error.Closes #209.
Add four offline Pkl regressions for the filename/ref fallback order and a nested action, using the repository's existing
pkl-pantry.testModeconvention.Validation with Pkl 0.32.1 (JVM):
--skip-publish-check.git diff --checkpassed.Local published-content checking reported a mismatch for the unchanged
com.github.actions@1.9.2dependency. The full Gradle CI suite was not run locally.