Skip to content

Add action.yaml fallback to remote metadata lookup - #244

Open
xili-ytl wants to merge 2 commits into
apple:mainfrom
xili-ytl:codex/fix-action-yaml-metadata
Open

xili-ytl wants to merge 2 commits into
apple:mainfrom
xili-ytl:codex/fix-action-yaml-metadata

Conversation

@xili-ytl

@xili-ytl xili-ytl commented Oct 18, 2026 •

Copy link
Copy Markdown

Try action.yaml when the existing action.yml lookups find no remote metadata, reusing the existing YAML parser. Preserve the lookup order and identify both filenames in the missing-metadata error.

Closes #209.

Add four offline Pkl regressions for the filename/ref fallback order and a nested action, using the repository's existing pkl-pantry.testMode convention.

Validation with Pkl 0.32.1 (JVM):

  • Affected package and four local dependencies: 64 tests / 95 assertions passed; packaging completed with --skip-publish-check.
  • Eight local HTTP regression cases passed with test mode absent.
  • Official Pkl formatting and git diff --check passed.

Local published-content checking reported a mismatch for the unchanged com.github.actions@1.9.2 dependency. The full Gradle CI suite was not run locally.

Read the alternative metadata filename when action.yml is absent,
while preserving the existing lookup precedence. This allows actions
that use action.yaml to be generated and resolves issue apple#209.

@StefMa StefMa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is misleading as we are already respecting .yaml files. You only add the tried urls to the failure message. Which is a little improvement 🤷‍♂️ 🙃

Add offline Pkl regressions for the existing lookup preference and the
tag, branch, and nested action.yaml fallbacks. Reuse the repository's
test mode convention to read local metadata fixtures.

Keep the normal GitHub URLs and lookup order unchanged.
@xili-ytl xili-ytl changed the title Support action.yaml metadata in ActionGenerator Add action.yaml fallback to remote metadata lookup Oct 18, 2026
@xili-ytl

Copy link
Copy Markdown
Author

Thank you for your review. I'm sorry my earlier description wasn't precise enough. I've clarified the PR description and added regression tests. I appreciate your time and feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[com.github.actions.contrib] ActionGenerator doesn't handle .yaml metadata extension

2 participants