Skip to content

DRAFT: Spacemit k1 current redux - #11035

Open
pyavitz wants to merge 2 commits into
armbian:mainfrom
pyavitz:spacemit-k1-current-redux
Open

pyavitz wants to merge 2 commits into
armbian:mainfrom
pyavitz:spacemit-k1-current-redux

Conversation

@pyavitz

@pyavitz pyavitz commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

DO NOT MERGE UNTIL TESTED

  • Cleaned up linux-spacemit-current.config
  • Reorganized 6.18.y patch set
  • Updated esos.elf to latest available

This is an attempt to stabilize the current branch, which over time has become unbootable. This appears to be a multi-pronged issue.

  1. Armbian is editing the defconfig from a known working config to what Armbian wants as defaults. This array needs an Opt out switch (or switches per section?) in my opinion or needs to be less aggressive in its approach.
lib/functions/compilation/kernel-config.sh: L131
	# Apply the modifications set in the arrays/dict
	armbian_kernel_config_apply_opts_from_arrays
  1. The armbian-hardware-optimize script b0rks usb storage devices. This script and service is just not stable on SpacemiT K1. I either disable the service or add an exit.
# Read in basic OS image information
. /etc/armbian-release

# Opt out
if [[ "$LINUXFAMILY" == "spacemit" ]]; then
	exit 0
fi

There may be more issues I have yet to discover. As for the two listed above; I'm not sure what the best approach to take there is. Anyway, what this PR needs is testing, testing and more testing.

Cleaned up linux-spacemit-current.config
Reorganized 6.18.y patch set
Update esos.elf to latest available

Signed-off-by: Patrick Yavitz <pyavitz@gmail.com>
Signed-off-by: Patrick Yavitz <pyavitz@gmail.com>
@pyavitz
pyavitz requested a review from igorpecovnik October 18, 2026 11:29
@pyavitz
pyavitz requested a review from sven-ola as a code owner October 18, 2026 11:29
@github-actions github-actions Bot added the 11 Milestone: Fourth quarter release label Oct 18, 2026
@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • wip
  • draft

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: armbian/build/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a40497b0-8887-4e67-ae95-9745e02f5a51

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size/medium PR with more then 50 and less then 250 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... BSP Board Support Packages labels Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release BSP Board Support Packages Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/medium PR with more then 50 and less then 250 lines

Development

Successfully merging this pull request may close these issues.

1 participant