[EvilOlaf]

Description

Fixes #11080

don't merge yet

How Has This Been Tested?

• hasn't since there is no 7.4 kernel yet

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• [?] My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• New Features
  • Added RTL8723BS driver preparation and kernel 7.4 support for Wi-Fi access point mode.
  • Improved handling of broadcast and multicast Wi-Fi traffic, including DTIM delivery, across USB and SDIO connections. This helps prioritize eligible traffic while keeping other frames on their appropriate queues.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: armbian/build
• Branch: main
• File: .coderabbit.yaml
• Commit: 57cb150
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: ef011c63-9a68-4adf-9241-6193e7c76546

📥 Commits

Reviewing files that changed from the base of the PR and between 57cb150 and 7150768.

📒 Files selected for processing: 4

• lib/functions/compilation/patch/drivers-harness.sh
• lib/functions/compilation/patch/drivers_network.sh
• patch/misc/rtw8723bs/0001-wifi-rtw88-move-the-bmc-high-queue-decision-to-tx.c.patch
• patch/misc/rtw8723bs/0002-wifi-rtw88-sdio-limit-the-high-queue-to-DTIM-delivery.patch

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The changes add RTL8723BS to the patch harness and apply two rtw88 AP-mode patches for kernel 7.4. The patches share BMC high-queue classification and budget handling across USB and SDIO transmit paths.

Changes: RTL8723BS AP-mode backport

Layer / File(s)	Summary
Register and select the kernel 7.4 patches lib/functions/compilation/patch/drivers-harness.sh, lib/functions/compilation/patch/drivers_network.sh	The harness considers RTL8723BS, and its driver function applies the two patches when the kernel version is 7.4.
Share BMC high-queue classification and budget patch/misc/rtw8723bs/0001-wifi-rtw88-move-the-bmc-high-queue-decision-to-tx.c.patch	The patch moves BMC classification and budget state into shared rtw88 TX code. USB calls the shared helper to select the high queue or retain skb->priority.
Apply DTIM queue limits to SDIO patch/misc/rtw8723bs/0002-wifi-rtw88-sdio-limit-the-high-queue-to-DTIM-delivery.patch	SDIO redirects frames from RTW_TX_QUEUE_HI0 to the hardware queue for their access category when the shared helper returns false.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant SDIO as SDIO transmit path
  participant Helper as rtw_tx_bmc_use_hiq()
  participant Queue as Hardware queue selection
  SDIO->>Helper: Check high-queue eligibility
  Helper-->>SDIO: Return eligibility
  alt Eligible
    SDIO->>Queue: Keep RTW_TX_QUEUE_HI0
  else Not eligible
    SDIO->>Queue: Select hardware queue for access category
  end

Loading

Merge Risk: ⚪ Minimal · up to 71507

No concrete issue identified here blocks merging, but the backport should be tested against kernel 7.4 before release.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (2 skipped: 2 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: backporting RTL8723BS AP-mode support to rtw88 for kernel 7.4.
Linked Issues check		Issue #11080 requires two rtw88 RTL8723BS AP-mode patches for kernel 7.4 builds. The PR includes both patches. driver_rtl8723bs() applies them for kernel version 7.4, and `kernel_drivers_prepare_har…
Out of Scope Changes check		The changed harness registration, version-gated patch application, and two rtw88 patches directly support Issue #11080. The shared USB and SDIO queue changes are required to apply the two upstream pat…

Full details: Linked Issues check

Explanation

Issue #11080 requires two rtw88 RTL8723BS AP-mode patches for kernel 7.4 builds. The PR includes both patches. driver_rtl8723bs() applies them for kernel version 7.4, and kernel_drivers_prepare_harness includes the driver unless it is skipped. The patch contents add the shared high-queue decision and apply the DTIM queue limit to the SDIO path. Issue #11080 does not specify an automated test requirement. The PR's stated lack of kernel 7.4 testing does not show a missing coding requirement.

Full details: Out of Scope Changes check

Explanation

The changed harness registration, version-gated patch application, and two rtw88 patches directly support Issue #11080. The shared USB and SDIO queue changes are required to apply the two upstream patches and preserve their behavior. No unrelated change is established.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[MocLG]

Reviewed-by: Luka Gejak luka.gejak@linux.dev