Repository navigation
Conversation
Layer: 3-one-precedence-order
Layer: 3-one-precedence-order
kmcginnes
force-pushed
the
t3/typescript-startup-stack-3-one-precedence-order
branch
from
November 18, 2026 02:22
02a70ae to
da2a254
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Startup settings came from different places in different orders, and
config.jsonreplaced every key it could hold even when it left one out. Every setting now follows one precedence order.Connection settings still never come from
.envor.env.localhere. The configuration reference documents the order, and an ADR records it.Upgrade notes
config.json, including the Default Connection settings andNEPTUNE_NOTEBOOK, and a settingconfig.jsonleaves out now comes from the environment. Where an-eflag andconfig.jsonset the same setting to different values, the-evalue now wins, so remove the flag to keep theconfig.jsonvalue.-e NEPTUNE_NOTEBOOK=true, the Neptune Notebook preset now applies even whenconfig.jsonexists, so the server serves HTTP on port 9250. WhenPROXY_SERVER_HTTPS_CONNECTIONis alsotrue, startup stops and names the conflict and how to resolve it.-evalue for a settingconfig.jsoncan hold, such as-e GRAPH_CONNECTION_URL=, counts as unset.Evidence
After: the scenario rows that combine
-eflags withconfig.jsonnow expect the-evalue, and the notebook-plus-HTTPS rows expect the conflict error.Verified live:
-e NEPTUNE_NOTEBOOK=truewith aconfig.jsonHTTPStruestops with the conflict message, and-e NEPTUNE_NOTEBOOK=falsethen serves HTTPS.Merge Danger
Door: two-way
Impact: breakage for deployments that set the same setting in both
-eandconfig.jsonwith different values.Related
🤖 Written by an AI agent on my behalf.