Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
b7r6
force-pushed
the
fix/eviction-rechecks-heartbeat
branch
3 times, most recently
from
October 8, 2026 17:51
ce608bf to
f7483a1
Compare
b7r6
force-pushed
the
fix/eviction-rechecks-heartbeat
branch
from
October 14, 2026 17:40
f7483a1 to
d154a5e
Compare
b7r6
force-pushed
the
fix/eviction-rechecks-heartbeat
branch
from
October 15, 2026 11:19
d154a5e to
113b729
Compare
Completes the no-per-PR-OCI-builds intent: image-off-pr moved image.yaml off PRs and TraceMachina#2877 moved the nix integration job off PRs, but main.yaml's integration-tests (docker-compose image build + run_integration_tests.sh) fell between them and still ran on every PR. Defer to nightly + merge-to-main, matching TraceMachina#2880's pattern. Fork-local until folded into the upstream OCI/nightly set.
…n remove_timedout_workers remove_timedout_workers had a TOCTOU window: it snapshots each worker's last_update_timestamp under the inner lock, releases the lock to consult the worker registry (an await boundary every sweep crosses), then re-acquires the lock and calls immediate_evict_worker using the stale snapshot. A keepalive processed in that window refreshes last_update_timestamp under the very same mutex, yet the sweep never re-consults it, so a demonstrably-alive worker is evicted and all of its running actions are requeued. Fix: after re-acquiring the inner lock, re-read the worker's last_update_timestamp and skip the eviction if it has moved past the timeout threshold. Because keepalives update the timestamp under the same mutex, the staleness decision and the eviction are now atomic with respect to keepalive processing. No new locking is added to any dispatch path. Kill-overdue evictions deliberately do not re-check: keepalives from a worker that refuses to acknowledge a kill are exactly the wedged-worker symptom that path exists to handle. Tests: two deterministic repros. One parks the sweep at the pre-existing await boundary via a cfg(test)-only Notify rendezvous and delivers a full worker_keep_alive_received; the other forces the interleaving with genuine lock contention (holding the registry write lock, then the inner lock) via a cfg(test)-only WorkerRegistry::write_lock_for_test accessor. Both fail without the fix and pass with it. The write_lock_for_test seam is kept: it exercises the window through real lock contention rather than the injected gate, so the two tests do not share a failure mode. Provenance: adversarial review fleet. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
b7r6
force-pushed
the
fix/eviction-rechecks-heartbeat
branch
from
October 21, 2026 17:25
113b729 to
1f21271
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Lane A stability fix from the findings catalog (see
nativelink-findings-2026-10-05.csvon the
meta/findings-catalog-2026-10-05branch), rebased onto OSS main@bf4b3aa855. This fork PR exists to validate the change on CI that is
representative of upstream PR lanes (public read-only cache, same endpoints)
before any upstream submission.
How was this verified?
The branch carries its own regression tests (fails-without where the fix
class allows it — see the branch's test commits). This PR's purpose is the
full representative CI run; green here rehearses the exact checks an
upstream PR would face.
Risk
Fork-internal validation PR; nothing lands anywhere by merging this. The
underlying fix's risk assessment happens at upstream-submission time.
AI assistance
Agent-assisted pipeline (Claude) for rebase and PR mechanics under my
direction; the fix itself carries verification in its tests.