Skip to content

fix(store): request an inclusive HTTP byte range in S3/ONTAP/GCS get_part - #54

Open
b7r6 wants to merge 2 commits into
mainfrom
b7r6/s3-range-off-by-one-overread
Open

b7r6 wants to merge 2 commits into
mainfrom
b7r6/s3-range-off-by-one-overread

Conversation

@b7r6

@b7r6 b7r6 commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

What and why

Lane A stability fix from the findings catalog (see nativelink-findings-2026-10-05.csv
on the meta/findings-catalog-2026-10-05 branch), rebased onto OSS main
@bf4b3aa855. This fork PR exists to validate the change on CI that is
representative of upstream PR lanes (public read-only cache, same endpoints)
before any upstream submission.

How was this verified?

The branch carries its own regression tests (fails-without where the fix
class allows it — see the branch's test commits). This PR's purpose is the
full representative CI run; green here rehearses the exact checks an
upstream PR would face.

Risk

Fork-internal validation PR; nothing lands anywhere by merging this. The
underlying fix's risk assessment happens at upstream-submission time.

AI assistance

Agent-assisted pipeline (Claude) for rebase and PR mechanics under my
direction; the fix itself carries verification in its tests.

@b7r6
b7r6 force-pushed the b7r6/s3-range-off-by-one-overread branch 3 times, most recently from 8b7f1df to 498f714 Compare October 8, 2026 15:12
@b7r6
b7r6 force-pushed the b7r6/s3-range-off-by-one-overread branch from 498f714 to 746ec08 Compare October 14, 2026 17:40
@b7r6
b7r6 force-pushed the b7r6/s3-range-off-by-one-overread branch from 746ec08 to 0a4fd06 Compare October 15, 2026 11:19
Completes the no-per-PR-OCI-builds intent: image-off-pr moved image.yaml off
PRs and TraceMachina#2877 moved the nix integration job off PRs, but main.yaml's
integration-tests (docker-compose image build + run_integration_tests.sh)
fell between them and still ran on every PR. Defer to nightly + merge-to-main,
matching TraceMachina#2880's pattern. Fork-local until folded into the upstream OCI/nightly
set.
…part

S3/ONTAP/GCS get_part built bytes={offset}-{offset+length}, but HTTP byte
ranges are inclusive on both ends, so a bounded read ending before the object
end over-read one byte (a torn read on content-addressed partial reads). Use
offset+length-1, guard zero-length reads, and fix the GCS mock (which sliced
exclusively and masked the bug). r2_store wraps s3_store, so S3/R2/ONTAP + GCS
are all covered.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant