Repository navigation
Conversation
b7r6
force-pushed
the
pr/config-check-flag
branch
3 times, most recently
from
October 8, 2026 03:39
6591f4d to
721b463
Compare
b7r6
force-pushed
the
pr/config-check-flag
branch
2 times, most recently
from
October 15, 2026 11:19
c9efe94 to
a0a5aea
Compare
Completes the no-per-PR-OCI-builds intent: image-off-pr moved image.yaml off PRs and TraceMachina#2877 moved the nix integration job off PRs, but main.yaml's integration-tests (docker-compose image build + run_integration_tests.sh) fell between them and still ran on every PR. Defer to nightly + merge-to-main, matching TraceMachina#2880's pattern. Fork-local until folded into the upstream OCI/nightly set.
`nativelink <config>` previously validated a config only by booting it (binding listeners, connecting to backends), so there was no way to check a config in CI without a live environment. Add `nativelink --check <config>`: it parses the config (already running check_store_conflict) and resolves every store/scheduler name reference — the typo'd-reference class that otherwise only surfaces at boot — then exits without constructing the store manager, binding a socket, connecting to any backend, or creating store directories. Success prints a one-line summary to stdout (exit 0); unresolved references and duplicate store/scheduler names are collected and reported to stderr, each with its config path (exit 1). CasConfig::validate_references walks workers and server services, and recurses ref_store references for the transitive closure of stores that are actually wired to a consumer. It is conservative to avoid false positives: optional/defaulted refs are checked only when present, and store-internal refs of unwired stores are skipped — so all 17 shipped example configs pass --check (proven offline via strace: zero network connects), while a dangling reference is named and fails. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
b7r6
force-pushed
the
pr/config-check-flag
branch
from
October 21, 2026 17:39
a0a5aea to
5993748
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Lane A stability fix from the findings catalog (see
nativelink-findings-2026-10-05.csvon the
meta/findings-catalog-2026-10-05branch), rebased onto OSS main@bf4b3aa855. This fork PR exists to validate the change on CI that is
representative of upstream PR lanes (public read-only cache, same endpoints)
before any upstream submission.
How was this verified?
The branch carries its own regression tests (fails-without where the fix
class allows it — see the branch's test commits). This PR's purpose is the
full representative CI run; green here rehearses the exact checks an
upstream PR would face.
Risk
Fork-internal validation PR; nothing lands anywhere by merging this. The
underlying fix's risk assessment happens at upstream-submission time.
AI assistance
Agent-assisted pipeline (Claude) for rebase and PR mechanics under my
direction; the fix itself carries verification in its tests.