Repository navigation
Conversation
Every workspace `.bazelrc` repeated the same downloader config, timeout scaling, and retry flags, requiring manual edits across 26 files whenever downloader settings change. Factor the shared flags into `downloader_cfg.bazelrc` (synced to `gazelle/` and `sphinxdocs/` via `dev/sync_downloader_configs.py`), add relative-path wrappers in `examples/downloader_cfg.bazelrc` and `tests/integration/downloader_cfg.bazelrc`, and update workspace `.bazelrc` files to import them.
Collaborator
Author
|
An AI coding agent assisted with authoring this pull request. The human author (@rickeylev) will review all feedback and either respond directly or review and approve any agent-assisted responses and changes before they are posted. This is an automatically generated agent comment. |
…l 10 In Bazel 10 (`10.0.0rc2`), `--downloader_config` (and its alias `--experimental_downloader_config`) changed from single-valued to `allowMultiple = true`, accumulating all specified config paths instead of overriding earlier ones. When sub-workspaces imported `downloader_cfg.bazelrc` and appended a relative path override, Bazel 10 attempted to read both `downloader_config.cfg` and the relative path. Keep the shared timeout and retry flags in `downloader_cfg.bazelrc` and set `--experimental_downloader_config` once per workspace depth in `.bazelrc`, `gazelle/.bazelrc`, `sphinxdocs/.bazelrc`, and the sub-workspace `downloader_cfg.bazelrc` wrappers.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every workspace
.bazelrcrepeated the same downloader config,timeout scaling, and retry flags, requiring manual edits across 26
files whenever downloader settings change.
Factor the shared flags into
downloader_cfg.bazelrc(synced togazelle/andsphinxdocs/viadev/sync_downloader_configs.py),add relative-path wrappers in
examples/downloader_cfg.bazelrcandtests/integration/downloader_cfg.bazelrc, and update workspace.bazelrcfiles to import them.