Skip to content

Prevent Style/YodaCondition from breaking not LITERAL - #4443

Merged
bbatsov merged 1 commit into
rubocop:masterfrom
pocke:fix-yoda
May 29, 2017
Merged

bbatsov merged 1 commit into
rubocop:masterfrom
pocke:fix-yoda

Conversation

@pocke

@pocke pocke commented May 29, 2017

Copy link
Copy Markdown
Collaborator

For example

!true
not true
!1
!'foo'

Style/YodaCondition cop crashes on the above cases.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@bbatsov

bbatsov commented May 29, 2017

Copy link
Copy Markdown
Collaborator

I guess it'd be better to simply ignore not, as it's not really interesting for this cop.

For example

```ruby
!true
not true
!1
!'foo'
```

`Style/YodaCondition` cop crashes on the above cases.
@pocke

pocke commented May 29, 2017

Copy link
Copy Markdown
Collaborator Author

Right. I updated the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants