Repository navigation
Handle 304 status for remote config files - #4485
Merged
bbatsov merged 1 commit intoJun 10, 2017
Merged
Conversation
Collaborator
|
The fix looks good, but it should be listed in the changelog. |
daniloisr
force-pushed
the
fix-remote-not-modified-reponses
branch
from
June 10, 2017 09:53
bcd2ff7 to
eb75fa0
Compare
Contributor
Author
|
@bbatsov done |
Contributor
|
@daniloisr add yourself to the bottom of the changelog too to get the build to pass. |
When remote file response is NotModified, we can reuse the existing cached file.
daniloisr
force-pushed
the
fix-remote-not-modified-reponses
branch
from
June 10, 2017 14:28
eb75fa0 to
de20b1e
Compare
Collaborator
|
👍 |
5 tasks done
This was referenced Nov 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all, when using remote config I was facing the following error:
On lines
lib/rubocop/remote_config.rb:48-49:This happens for 304 HTTPNotModified responses, which don't have the
'location'key.(and to help reviewers, 304 responses occurs due this header)
So my solution is to just handle this response and reuses the existing cached file.